GNOME Bugzilla – Bug 477799
New Login (gdmflexiserver) only use one size of the icon
Last modified: 2010-06-04 20:22:58 UTC
Please describe the problem: The new login icon is only in one size (48x48) and therefore looks blurry when displayed in the menu. Hylke Bons has drawn a new icon in several sizes that can be used instead. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 95740 [details] before and after new icon
Created attachment 95741 [details] gdmflexiserver icon to be installed into icons/hicolor instead of pixmaps like now. should probably say Icon=gdmflexiserver in the gdmflexiserver.desktop-file as well.
Created attachment 95782 [details] better gdmflexiserver icon from Lapo Calamandrei more visible "new"-star.
What is needed to integrate this new icon into GDM, just replace the existing icon or are changes needed to Makefile.am files, etc.? Also, is the author of the image agreeable to allow the image to be released under a GPL license? I assume so, but want to ask.
Adding Luca to cc
I'll take a look in the next days. This isn't stuff for 2.20, so we don't need any rapid solution, is it? (same for bug #477983)
Correct. This will go into the next release of GDM, most likely.
Before I star to change anything, just a question. We have 2 way to install icons, or, better, include them in source tree. #1 g-i-t approach Add a directory structure like the one in gnome-icon-theme and put the icon in the proper one (<size>/<role>/) using the "named icon name" as filename for the icon. Files to add: gdm/ +- icons + +- 16x16/ +- apps/ --> gdmflexyserver.png +- 22x22/ +- apps/ --> gdmflexyserver.png +- 32x32/ +- apps/ --> gdmflexyserver.png +- scalable/ +- apps/ --> gdmflexyserver.svg plus a Makefile.am for each directory. #2 epiphany approach Add a single "icons" directory storing all icons at all sizes (the filename for each icon is something like <icontheme>_<size>_<role>_<namedicon>.<ext>) and use some Makefile rules to install icons See http://svn.gnome.org/viewvc/epiphany/trunk/data/icons/ Files to add: * gdm/data/icons/hicolor_16x16_gdmflexyserver.png * gdm/data/icons/hicolor_22x22_gdmflexyserver.png * gdm/data/icons/hicolor_32x32_gdmflexyserver.png * gdm/data/icons/hicolor_scalable_gdmflexyserver.svg * gdm/data/icons/Makefile.am Which one the GDM developer will like to use? The second one seems a little tricky, but you don't need to add directories and configure/makefile rules in order to provide new icons (for example a11y icons or custom application icons): just add a file with the proper name and an entry in data/icons/Makefile.am.
I think approach #1 would be reasonable. Note that GDM SVN head is a pretty significant rewrite. You might want to hold off on this until SVN head is a bit more stable to figure out what we should do here? I'm not sure that we will even support gdmflexiserver going forward. Or if you want to provide a patch for 2.20, then we could apply that and rework SVN head later. Then people who use 2.20 would have better icon support.
Created attachment 97892 [details] [review] The patch to apply This is the patch to apply (against gnome-2-20 branch) in order to: * don't install gdm-setup.png files under ./pixmaps/ directory * cleanup Makefiles under ./pixmaps/ in order to run update-icon only once * use new named icons ("gdmsetup" and "gdmflexiserver") in .desktop files and in gdmsetup binary * provide changes to ./configure.ac and ./Makefile.am in order to use new ./data/icons/ directory (see next attachment)
Created attachment 97893 [details] The tgz file storing the new ./data/ directory Here are directories, images and Makefile.am files (it seems that "svn diff" is unable to store new files, or at least I don't know how to do). You simply have to extrat it in gdm sources root directory. It's ./data/icons/ and not ./icons/ 'cause this is the tree used on other applications such as EoG and Epiphany. ./data/ directory is used to store also .schemas, .glade, .desktop and other non-source files. Could be useful to gdm too. The tgz stores also gdmsetup icons from the other bug (# 477983) If it's OK, I can apply to svn (also running `svn rm pixmap/*/gdm-setup.png`).
Yes, this looks good for the 2.20 branch. Just make sure that "make", "make install", "make clean" and "make uninstall" all work as expected with your changes. You can also test by running "make distcheck" and making sure that this change doesn't introduce any new problems. When we change the way we install files, it is pretty common that these break if you don't test them. One question I have, some of the icons/*/apps directories contain files like gdmflexiserver.xcf.bz2. These files are marked as not to be installed and don't seem to be used in the build process. I assume these are GIMP files that contain the original image that you created? It might be nice to put a README in the toplevel icons directory explaining what these files are, any tips for people who need to make changes in the future, and how we plan to maintain icons in the 2.20 branch. Please close this bug when you are done.
(In reply to comment #12) > Yes, this looks good for the 2.20 branch. Just make sure that "make", "make > install", "make clean" and "make uninstall" all work as expected with your > changes. You can also test by running "make distcheck" and making sure that > this change doesn't introduce any new problems. When we change the way we > install files, it is pretty common that these break if you don't test them. Yeah, I know I forgot to add at least MAINTAINERCLEANFILES = Makefile.in > One question I have, some of the icons/*/apps directories contain files like > gdmflexiserver.xcf.bz2. These files are marked as not to be installed and > don't seem to be used in the build process. I assume these are GIMP files that > contain the original image that you created? Yes, they are the "source" of installed icons, needed for future changes/tweaking. They should live only on svn repository, following the gnome-icon-theme behavior. > It might be nice to put a README > in the toplevel icons directory explaining what these files are, any tips for > people who need to make changes in the future, OK, I'll put here the text before committing. > and how we plan to maintain > icons in the 2.20 branch. ??
(In reply to comment #13) > (In reply to comment #12) > > Yes, they are the "source" of installed icons, needed for future > changes/tweaking. > > They should live only on svn repository, following the gnome-icon-theme > behavior. > ... but some other applications ships them in source packages. I simply copied the template Makefile.am from a module that choose to provide them. What's the behavoir you preferr? Only on svn on in tgz too?
I don't really care if they are in SVN only or also in the source. Having them in the source makes it a little easier for people to modify them if they want, rather than having to dig around SVN for them. But if they are big in size, it's probably better to leave them in SVN only. When I said "and how we plan to maintain icons in the 2.20 branch." I just meant that the README should contain some information to people about how the icons are being maintained in GDM, so if someone wants to add a new icon or something, its easy for them to figure out how to do so.
Andreas, do you have the time to provide "gdmflexiserver-xnest" icon (for launcher) too?
Luca: Sure. Will try to come up with something in the following days.
OK, stuff committed. Please read the README file and let me know if you can understand it :-) http://svn.gnome.org/viewvc/gdm/branches/gnome-2-20/data/icons/README?view=markup (If it's OK, you can close the bug, or wait for new icon from Andreas)
Please close after the file is provided and added to the 2.20 branch.
Any update? Where is the new gdmflexiserver-xnest icon?
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.