GNOME Bugzilla – Bug 473482
GtkStatusIcons are cropped on small sizes
Last modified: 2014-08-30 05:20:10 UTC
Please describe the problem: Especially on smaller tray sizes, the icons are chopped. After some testing, it look like using gtk_icon_theme_load_icon works better in those cases. As a result the icons are a bit fuzzy sometimes, but personally I think that's better then cropped icons. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 94906 [details] [review] Patch again gtkstatusicon.c This patch shows the changes need in gtk, I haven't tried it inside gtk, only on the size-change signal of a status icon.
Hello gtk developper, could you look at the patch ? Thanks
Good patch! But could use some more work: + if (G_LIKELY (gtk_widget_has_screen (priv->image))) + icon_theme = gtk_icon_theme_get_for_screen (gtk_widget_get_screen (priv->image)); + else + icon_theme = gtk_icon_theme_get_default (); Instead use gtk_icon_theme_get_for_screen (gtk_status_icon_get_screen (status_icon)). The two chunks of code you are inserting are identical, so it makes sense to break it out into a function. As a last refactoring you could also try and unify the parts of the paths for X11, WIN32 and QUARTZ since with your patch they become very similar.
@Nick: Could you update your patch with the Björn comments?
GtkStatusIcon has been deprecated