After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 472647 - style properties in message area
style properties in message area
Status: RESOLVED OBSOLETE
Product: gedit
Classification: Applications
Component: general
2.19.x
Other Linux
: Normal trivial
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-01 20:47 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2009-01-01 15:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
style properties for message area (3.18 KB, patch)
2007-09-01 20:49 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review
message area (3.17 KB, patch)
2007-09-02 09:21 UTC, Ignacio Casal Quinteiro (nacho)
needs-work Details | Review
patch (4.25 KB, patch)
2008-01-22 21:03 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review
message-area (4.61 KB, patch)
2008-01-22 21:10 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review

Description Ignacio Casal Quinteiro (nacho) 2007-09-01 20:47:36 UTC
i will attach a patch for this.
Comment 1 Ignacio Casal Quinteiro (nacho) 2007-09-01 20:49:12 UTC
Created attachment 94775 [details] [review]
style properties for message area

There were some FIXME comments in message area. This patch fix that feature request.
Comment 2 Ignacio Casal Quinteiro (nacho) 2007-09-02 09:21:05 UTC
Created attachment 94799 [details] [review]
message area

Corrected a Gtranslator instead of Gedit data type
Comment 3 Steve Frécinaux 2007-12-28 23:34:23 UTC
Comment on attachment 94799 [details] [review]
message area

>+#define GTK_PARAM_READABLE G_PARAM_READABLE|G_PARAM_STATIC_NAME|G_PARAM_STATIC_NICK|G_PARAM_STATIC_BLURB

You should not define anything in the GTK_ namespace... Why not use G_PARAM_READABLE|G_PARAM_STATIC_STRINGS directly?

>+	update_spacings(message_area);

There is a missing space here. Also, since it's the only place this function is called, why not putting it inline here directly?
Comment 4 Paolo Maggi 2007-12-30 08:36:01 UTC
Maybe I'm confused but I think there is something wrong in the patch.

To change the space between buttons you should change the spacing of action_area not main_hbox.

To set the content-area-border style property you should change the border of the "contents" not of the main_hbox (this could be a bit tricky to implement).

I suggest you to look at GtkDialog implementation to see how the properties are set there.

See also comment #3 by Steve.


Comment 5 Ignacio Casal Quinteiro (nacho) 2008-01-22 21:03:28 UTC
Created attachment 103490 [details] [review]
patch

What about this?
Comment 6 Ignacio Casal Quinteiro (nacho) 2008-01-22 21:10:04 UTC
Created attachment 103491 [details] [review]
message-area

I forgot a variable
Comment 7 Ignacio Casal Quinteiro (nacho) 2009-01-01 15:49:14 UTC
If we want this we can always resurrect this bug. Marking this as obsolete.