GNOME Bugzilla – Bug 471878
ARIA widgets should not echo characters during traversal using arrows
Last modified: 2008-07-22 19:32:22 UTC
The ARIA tree seen here http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Tree.html triggers a caret-moved event that leads to a character echo when expanding/collapsing. The following is an event log of a single expansion event: object:text-changed:delete(2, 1, ) source: [tree | ] application: [application | Minefield] object:text-changed:insert(2, 1, ) source: [tree | ] application: [application | Minefield] object:state-changed:expanded(1, 0, None) source: [list item | Asia] application: [application | Minefield] object:property-change:accessible-parent(0, 0, [tree | ]) source: [list item | Africa] application: [application | Minefield] object:children-changed:add(0, 0, [list item | Africa]) source: [tree | ] application: [application | Minefield] object:text-caret-moved(0, 0, None) source: [list item | Asia] application: [application | Minefield] The solution will be to short-circuit this event in onCaretMoved().
Created attachment 94652 [details] [review] first version of ARIA widgets should not echo characters This patch add a fifth possibility of an early return to onCaretMoved(), this time for ARIA widgets when an arrow key has been pressed. Joanie has added the fourth possibility in another uncommitted patch. This patch also fixes the listbox bug seen here http://bugzilla.gnome.org/show_bug.cgi?id=468968
This fix still looks fine. However, Firefox is not providing state EXPANDABLE for collapsed branches now. See https://bugzilla.mozilla.org/show_bug.cgi?id=394868 . The result of this bug causes 'collapsed' output to fail.
Will, This patch fixes this bug and testing can still be done regardless of the Mozilla state EXPANDABLE bug. This fix impacts many other bug fixes, especially the listbox issues you brought to my attention. Developing on top of multiple patches is a bit of a pain. It would help me out a great deal if we could get this one in.
I'll need to test with it some, but this patch looks good to me. I think it is harmless enough to check into trunk, though. We can always back things out if needed.
committed to trunk.