After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 468325 - Web searches extension broken
Web searches extension broken
Status: RESOLVED WONTFIX
Product: deskbar-applet
Classification: Deprecated
Component: Modules
Git master
Other Linux
: Normal normal
: 2.24
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
gnome[unmaintained]
: 427598 483683 484189 490887 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-19 22:00 UTC by Michael Monreal
Modified: 2011-07-10 02:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Screenshot (148.37 KB, image/png)
2007-08-19 22:01 UTC, Michael Monreal
Details
firefox 2 search plugin (23.02 KB, text/x-python)
2007-09-29 16:21 UTC, Peter Van den Bosch
Details

Description Michael Monreal 2007-08-19 22:00:51 UTC
The web searches extension seems to supply more search engines then what I have in my firefox. Also, when running in "only primary search engine" mode, all the engines are shown nevertheless.
Comment 1 Michael Monreal 2007-08-19 22:01:34 UTC
Created attachment 93954 [details]
Screenshot

To better illustrate what I mean...
Comment 2 Michael Monreal 2007-08-19 22:21:15 UTC
Hmm it seems to pick up the pre-installed engines from the system... I think it should have teh exact same list of engines as in the user's firefox profile, so if he/she deleted one of the defaults, it should not show up again.

The "primary search engine" thing is valid anyway
Comment 3 Sebastian Pölsterl 2007-09-06 16:07:44 UTC
I fixed that only the primary search engine is shown when this option is enabled.
Regarding the other issue. I have no idea where firefox stores which search engines are enabled/disabled.
Comment 4 Michael Monreal 2007-09-06 20:25:39 UTC
Yeah, fixed, the second issue can be disregarded.
Comment 5 Peter Van den Bosch 2007-09-29 16:21:57 UTC
Created attachment 96379 [details]
firefox 2 search plugin
Comment 6 Peter Van den Bosch 2007-09-29 16:22:28 UTC
The list of user search engines can be found in an sqlite db in the search.sqlite file in the user profile directory. I've taken the liberty of adapting the existing mozilla search handler. The result is in the attachment, ready to be dropped under ~/.gnome2/deskbar-applet/modules-2.20-compatible

The order of the search engines is now also taken into account, but this seems to break ordering of the module in the deskbar preferences. Don't know yet how to set the priorities of the matches correctly.
Comment 7 Sebastian Pölsterl 2007-09-29 18:36:13 UTC
(In reply to comment #6)
First of all, thanks a lot for taking the time to improve the Mozilla module.

> The list of user search engines can be found in an sqlite db in the
> search.sqlite file in the user profile directory. I've taken the liberty of
> adapting the existing mozilla search handler. The result is in the attachment,
> ready to be dropped under ~/.gnome2/deskbar-applet/modules-2.20-compatible
> 
The big problem is that Deskbar has to work with Python 2.4 according to GNOME policy. Unfortunately, the sqlite3 module is not part of Python 2.4 nor is it a blessed external Dependency.

> The order of the search engines is now also taken into account, but this seems
> to break ordering of the module in the deskbar preferences. Don't know yet how
> to set the priorities of the matches correctly.
> 
Use module's set_priority_for_matches method
Comment 8 Sebastian Pölsterl 2007-10-06 10:58:16 UTC
*** Bug 483683 has been marked as a duplicate of this bug. ***
Comment 9 Loïc Minier 2007-10-06 17:45:43 UTC
(In reply to comment #7)
> (In reply to comment #6)
> First of all, thanks a lot for taking the time to improve the Mozilla module.
> 
> > The list of user search engines can be found in an sqlite db in the
> > search.sqlite file in the user profile directory. I've taken the liberty of
> > adapting the existing mozilla search handler. The result is in the attachment,
> > ready to be dropped under ~/.gnome2/deskbar-applet/modules-2.20-compatible
> > 
> The big problem is that Deskbar has to work with Python 2.4 according to GNOME
> policy. Unfortunately, the sqlite3 module is not part of Python 2.4 nor is it a
> blessed external Dependency.

Can't you make that an optional dependency detected at runtime (and perhaps also checked at configure time to print a warning for packagers) or would that also infringe with GNOME policy?
Comment 10 Sebastian Pölsterl 2007-10-07 10:25:49 UTC
*** Bug 484189 has been marked as a duplicate of this bug. ***
Comment 11 Sebastian Pölsterl 2007-10-07 10:26:57 UTC
Reopened because second issue hasn't been solved, yet.
Comment 12 Sebastian Pölsterl 2007-10-16 13:55:18 UTC
*** Bug 427598 has been marked as a duplicate of this bug. ***
Comment 13 Sebastien Bacher 2007-10-18 09:32:40 UTC
There is a similar issue described on https://bugs.launchpad.net/deskbar-applet/+bug/122270

"Steeps to reproduce:
 1. Add deskbar-applet to a toolbar.
 2. Right click on it and choose "Preferences".
 3. Select "Search on the web" and click "More...".
 4. Select "Show only primary search engine".
 5. Close the preferences window and click on the applet.
 6. The search box will appear, write something there and wait a second.

Result:
 It will show all search engines installed on Firefox.

Expected Result:
 It should only show the primary search engine (that one that is selected on Firefox).
...
well i don't know how deskbar-applet reads the default search engine out of mozilla prefs ... but if it does not find a setting for .selectedEngine, it should use browser.search.defaultenginename instead.
...
No its not set in profile prefs.js because you don't have overwritten
the firefox system setting ... which might be set somewhere in
/usr/lib/firefox/defaults/pref

applications that want to read firefox preferences have to ensure that
they read global settings as well ..."
Comment 14 Susana 2007-10-28 09:46:43 UTC
*** Bug 490887 has been marked as a duplicate of this bug. ***
Comment 15 Akhil Laddha 2011-07-10 02:25:06 UTC
deskbar-applet development has been stalled [1]. Maintainers don't have future development plan so i am closing the bugs as WONTFIX.

[1] http://mail.gnome.org/archives/desktop-devel-list/2011-June/msg00073.html