After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 467545 - F-spot gets stuck in a loop if there's an exception on start
F-spot gets stuck in a loop if there's an exception on start
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.4.x
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-17 04:36 UTC by Eric Butler
Modified: 2007-12-08 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
please-dont-loop-forever-on-exception.patch (766 bytes, patch)
2007-12-08 08:22 UTC, Maxxer
committed Details | Review

Description Eric Butler 2007-08-17 04:36:28 UTC
If f-spot throws an exception inside Main, it gets stuck in a loop claiming (incorrectly) that it's unable to connect to dbus... over, and over, and over again.

This is caused by the "while (control == null)" loop, which seems to assume that if we keep trying, things will eventually work out for the best :).

The chance of this happening, however, is greatly reduced because 'create' never gets re-set to true, so after the first try, no more attempts to set things up are made.


Initializing Mono.Addins
Starting new FSpot server
XXXXX
Mono.Data.SqliteClient.SqliteSyntaxException: file is encrypted or is not a database
  at Mono.Data.SqliteClient.SqliteCommand.GetNextStatement (IntPtr pzStart, System.IntPtr& pzTail, System.IntPtr& pStmt) [0x00000] 
  at Mono.Data.SqliteClient.SqliteCommand.ExecuteReader (CommandBehavior behavior, Boolean want_results, System.Int32& rows_affected) [0x00000] 
  at Mono.Data.SqliteClient.SqliteCommand.ExecuteReader (CommandBehavior behavior) [0x00000] 
  at Mono.Data.SqliteClient.SqliteCommand.ExecuteReader () [0x00000] 
  at Mono.Data.SqliteClient.SqliteCommand.ExecuteScalar () [0x00000] 
  at Banshee.Database.QueuedSqliteCommand.Execute () [0x00000] 
XXXXX
Can't get a connection to the dbus. Trying again...
Starting new FSpot server
Can't get a connection to the dbus. Trying again...
Starting new FSpot server
Can't get a connection to the dbus. Trying again...
Comment 1 Eric Butler 2007-08-17 04:48:23 UTC
Since the initial exception is quickly scrolled off screen, people may not see it at all, and mistakenly try to debug a non-existent problem with dbus. Please only display the "Can't get a connection to the dbus" error if that's indeed what happened.
Comment 2 Maxxer 2007-12-08 08:22:07 UTC
Created attachment 100574 [details] [review]
please-dont-loop-forever-on-exception.patch

this patch makes f-spot return to console after 5 failed retries
Comment 3 Stephane Delcroix 2007-12-08 08:32:23 UTC
fixed in r3484