GNOME Bugzilla – Bug 467115
Missing icons for different modules
Last modified: 2008-08-08 13:41:27 UTC
Please describe the problem: Some distros, like Fedora ship Mail, Calendar, Tasks etc as different menu items with their own desktop-files. Evolution only have a application icon for the whole package though. Some time ago, Hylke Bons [1] did some sweet icons for the different parts [2]. What about shipping these with evolution? 1. http://bomahy.nl/hylke/blog/ 2. http://tango.freedesktop.org/Tango_Fridays#Friday_December_15th Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 93755 [details] Hylke's icons Should be installed into icons/hicolor, just like the normal evolution icon.
I think then, it makes sense to have a proper .desktop file also. What is the point in just having these icons shipped and not the desktop files? Any reason you think? Im sure that these icons are nice, and can be very well used, once we split things.
Yeah, that would be neat. I'll see if I can get hold of the desktop-files fedora ship.
Created attachment 97218 [details] Mockup The question is, IF evo ships desktop files for every component, will we also use these icons for the component switcher? The attachment shows a) the current look (mixed old/new icons b) a complete tango look I quickly copied together myself c) the proposed component icons IMHO c) looks a bit out of place. The white/blue icons look great in the menu (and show some kind of stand-together) but in evo itself it doesn't seem to work very well. Then again, having the switcher icons look very different from the launcher icons is bad, too. So what about this: we rework the (IMHO calendar and tasks don't look very nice) and provide 2 versions of them: one for the launcher, which will have the same color theme for all components (like the white/blue). The other version, for use in evo itself can use more color etc to look less "branded" I would also change the blue to purple, as that is what the current evolution icon uses (white letter, purple clock). We should stay close to that.
FWIW when I compare it, I liked the TANGO theme than the other things.
Bumping version to a stable release.
Michael: I really like option number 2. Lets see if we can fix this. Anything needs to be drawn?
I think this was kind of hold up by Bug 501354 (rethinking what *-new actions should be in the drowpdown and giving them proper icons)... but as I don't think that one will be fixed for 2.24, it would still be nice to resolve this one. For a few releases, addressbook and calendar now use tango icons now but the mail, tasks and memo components still use the old artwork. The discussion to use branded "evo component icons" (like option 3 above) does not seem to get anywhere. So I propose we go for option 2 for Evo 2.24. I have a patch and those icons I used for the mockup above. Need to check back b/c of licenses but let's first agree to do this.
Created attachment 115893 [details] Screenshot showing the changes
Be quick, UI Freeze is August 18. And I'd also love to see a fix for the old Evolution icon that I get when alt+tab. ;-)
Created attachment 115894 [details] [review] Patch #1 This patch changes the stock_* icons used for the component switcher (buttons and menu) to the new ones which need to be shipped by evo (makefile also adapted to do this). I also changed the small component images above the tree view to use the same icons. This works without a problem. Only thing I propose to change is to install the icons into the public hicolor apps directory so that they can be used for launchers as well (would be trivial to replace them with branded versions if that should happen in the future!)
Created attachment 115895 [details] Icons to drop into data/icons
(In reply to comment #10) > Be quick, UI Freeze is August 18. If there's agreement to have this in for 2.24 then it will be :) > And I'd also love to see a fix for the old > Evolution icon that I get when alt+tab. ;-) You see the component icon, right? Well, evolution seems to force the use of the 24x24 component icon for this, no idea why. We can try fixing this as part of another bug. Note: if Evo is minimized the switcher will (try to) display a 48x48 icon. The stock_* icons currently used are only available as 16x16 and 24x24 so they will never look nice. Only hope would be to provide also 32 and 48 sizes in addition to the sizes I already included here and then fix evo to not force one size but use an icon name instead.
Sweet work Michael! Thumbs up from me!
Created attachment 115901 [details] [review] Patch #2 This is just like patch #1 but I added the evolution-* prefix to the icon names and made them install into the public hicolor. (Note: this patch does not build atm because I added more icon sizes which are not currently part of the tar) Now waiting for decision of the maintainers.
+1 from me. The new icons look great! FYI regarding the original problem description: I dropped the per-component desktop files from Fedora earlier this year. They were too much of a maintenance hassle and confused poor Bug Buddy to no end. We now use the single desktop file that upstream ships, unpatched.
Also, the patch itself looks fine so I'm marking it Reviewed. Srini should give it final approval.
They look awesome. Go ahead Michael :-)
Thanks. I'm sorting out potential license problems regarding the icons now, but that should not take too long. (In reply to comment #10) > And I'd also love to see a fix for the old > Evolution icon that I get when alt+tab. ;-) > I just had a quick look. Currently the window icon is set to the same pixmap which is used on the button (shell/e-shell-window.c): gtk_window_set_icon (GTK_WINDOW (window), info->button_icon); What we need is gtk_window_set_icon_name (GTK_WINDOW (window), icon_name); where icon_name is the name of the icon used on button_icon. Is there an easy way to get this, from "info" for example? Or will we need to check for component name and match those against the right icon names (not so nice).
Check query_components() in e-component-registry.c. We actually do read an icon name from the Bonobo "server" file to begin with and then immediately create a GdkPixbuf from it. That last part is unnecessary; better to store off an icon name. I /think/ if you just change the EComponentInfo definition like so... struct _EComponentInfo { ... - GdkPixbuf *button_icon; + char *button_icon_name; ... }; ...the complexities should just fall out. Make sense? Maybe do the same to the "menu_icon" field too, while you're at it. Note: I'm in the process of rewriting all this cruft for 2.26 anyway, so it doesn't have to be pretty.
(In reply to comment #20) > ...the complexities should just fall out. Make sense? Sounds nice, I tried that already :) But at some point I was getting lots of bonobo_ui_util_xml_to_pixbuf: assertion `length > 4 * 2 * 2 + 1' failed so there seems to be hidden usage of the pixbuf... I tried to adapt all the e_* I could find but some are passing the pixbuf around so this is a bit over my head, sorry.
Ugh. So Bonobo gets in the way again. :/
Checked in as r35915: 2008-08-06 Michael Monreal <mmonreal@svn.gnome.org> ** Fix for bug #467115 * addressbook/gui/component/addressbook-view.c: (addressbook_view_init): * calendar/gui/GNOME_Evolution_Calendar.server.in.in: * calendar/gui/memos-component.c: (create_component_view): * calendar/gui/tasks-component.c: (create_component_view): * data/icons/Makefile.am: * mail/GNOME_Evolution_Mail.server.in.in: * mail/mail-component.c: (impl_createView): Ship and use tango icons for the mail, tasks and memos components. Note: no icon sources committed, I will have to wait for Jimmac to return and provide the tasks icon sources first. @Matthew: do you think fixing the window (and -switcher) icon is possible for 2.24? Icon-wise this is possible now but I'm not able to get it to work.
There's much more evil stuff. Just saw the alt+tab icon of an open contact editor. it's something blurry, can't recognize it.
(In reply to comment #24) > There's much more evil stuff. Just saw the alt+tab icon of an open contact > editor. it's something blurry, can't recognize it. > Yeah but that's no big deal if we had a new icon. The one currently used is the old one from pixmaps/. Does it make sense to have a separate icon for this dialog btw? Using the evolution icon (or addressbook component icon) would be easy. If not: the spec only has contact-new, so I guess we would need to ship a contact icon without the star in Evo itself. But let's discuss this in another bug. If you file one, cc me :)
(In reply to comment #23) > @Matthew: do you think fixing the window (and -switcher) icon is possible for > 2.24? Icon-wise this is possible now but I'm not able to get it to work. Referring to comment #19? Should be doable. A variation of my previous suggestion would be to store /both/ the icon name and pixbuf in EComponentInfo, if Bonobo insists on dealing only with pixbufs.
Created attachment 116017 [details] [review] Supplemental patch Reopening with a patch for the approach I described in comment #20. I was able to get past the problem Michael described by changing the generated BonoboUI XML from pixtype="pixbuf" to pixtype="filename".
Matt, looks fine to me.(I haven't tested though)
I just compiled this and it works very well. Big improvement IMHO and totally worth having for 2.24! I'm currently looking for other window icons which could need some love, too.
The icon for memo button (View->Switcher Appearance->Hid buttons unchecked) is missing for me; also when going to memos component, there is no icon at left-top corner, as I can see for any other components like mail/calendar/... I also tried to reconfigured and wholly recompiled evolution, but no luck, the icon is still missing. I've Fedora 9 at the moment, but I guess that icon was supposed to be part of evolution source, if I got it right.
That's strange, it's working for me... check for $PREFIX/share/icons/hicolor/16x16/apps/evolution-memos.png and $PREFIX/share/icons/hicolor/24x24/apps/evolution-memos.png ... no idea why it should not work for you.
Created attachment 116043 [details] sample The files are there. I noticed the tasks icon has a blue check, in both 16x16 an 24x24, but I see a red check (the old one I guess) in the evolution UI. I also noticed, when I'm in mail view, then the upper left icon of the mail is quite bigger.
Uhm this is not right. There should be a new-style letter icon at the top (more gray outline than black), also the tasks icon is still the stock_* which makes no sense. It hints that you are not using trunk or have some conflicts. Please check svn up && svn st to see if it's really upstream trunk.
Eh... check if you have icons named evolution-mail / tasks / memos in gnome-icon-theme ($PREFIX/share/icons/gnome/24x24/apps/*). If yes, damn... Those are not shipped with the version of g-i-t I have (trunk) but if they have been shipped with earlier versions. This this does not explain the missing memos icon.
from .svn/entries: 35920 svn+ssh://svn.gnome.org/svn/evolution/trunk I do not have a folder $PREFIX/share/icons/gnome, I have there only 'hicolor' directory.
Perhaps GTK+ is not looking in the right place for your icons. The Icon Theme Specification says: "Icons and themes are looked for in a set of directories. By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order)." You might need to set your XDG_DATA_DIRS environment variable to $PREFIX/share.
It doesn't explain why I see icons for tasks and calendar, those were changed too, right? I tried with the variable and I can see the memos icon now, but tasks is still same, same as the other icons on the screenshot I uploaded before. Something strange on my machine probably.
Committing the patch (revision 35924). If there /is/ an outstanding issue here I doubt it's related to the code changes.
I know it shouldn't, at least not directly, but going back to the revision 35914 fixes all issues I showed in the screenshot. Anyway, if you are sure it's only with my configuration, then I'm fine with it, feel free to close this bug.
Milan, what you see is partly related to an old gnome-icon-theme installation. I don't know where you have the gnome theme (jhbuild root?) but it still seems to be a version 2.22.x version, which had evolution-mail and evolution-tasks named icons in 24x24/apps, so you are seeing those. Now if you use a newer gnome-icon-theme you will proabbly not see any mail or tasks icon. I don't really understand why but we have to find out. Do you have $PREFIX/share/evolution/2.24/icons/ and do you find the memos icon in there (under apps for each size)? Also, do you see the calendar icons inside the calendar component (day/week/month) in the toolbar?
Could it be that his icon cache under $PREFIX is old or non-existent? Not exactly sure how the cache works, but I know that "make install" won't regenerate it for you. You have to run "gtk-update-icon-cache".
Well in share/evolution/2.24/icons/hicolor we don't have a cache and the cache of share/icons/hicolor (where the icons in question are located) is updated. Just checked, it seems to work fine (data/icons/Makefile.am line 115ff)
Created attachment 116081 [details] Contact editor icons + patch As Andre noticed the ugly window icon in the contacts editor, here's a possible fix. The icons are gnome-icon-theme's contact-new without the star, so they are GPL2 (to be LGPL'd soon). Put them in now? Wait? You decide.
Is that going to create a problem in themes that override contact-new? Won't we get inconsistent icons? (Or maybe we don't care?)
(In reply to comment #44) > Is that going to create a problem in themes that override contact-new? Won't > we get inconsistent icons? (Or maybe we don't care?) > Depends... I don't think there are many ways to draw a contact card :) plus, this one is very generic and not even using color, so the possibility is very small that it clashes with any other icon theme out there I would say. There's no contact or contact-editor in the spec, so we can't really do much about that anyway. That said, Evo always prefers icons with the same name from the theme, so if the theme has a contact-editor icon, it would get used.
(In reply to comment #40) > Milan, what you see is partly related to an old gnome-icon-theme installation. > I don't know where you have the gnome theme (jhbuild root?) but it still seems > to be a version 2.22.x version, which had evolution-mail and evolution-tasks > named icons in 24x24/apps, so you are seeing those. OK, that can explain it, I'm using Fedora 9, where is 2.22 and I do not compile my own gtk+/gnome*/... things especially for this. I also do not use jhbuild, I compile only that what I want to. > Now if you use a newer gnome-icon-theme you will proabbly not see any mail or > tasks icon. I don't really understand why but we have to find out. Do you have > > $PREFIX/share/evolution/2.24/icons/ I have there ($PREFIX/share/evolution/2.24/icons/hicolor/16x16/) only "actions, places" no "apps" there. > and do you find the memos icon in there (under apps for each size)? Also, do > you see the calendar icons inside the calendar component (day/week/month) in > the toolbar? Yes, these are in /share/evolution/2.24/icons/hicolor/16x16/actions/ I guess. (In reply to comment #41) > Could it be that his icon cache under $PREFIX is old or non-existent? Not > exactly sure how the cache works, but I know that "make install" won't > regenerate it for you. You have to run "gtk-update-icon-cache". I see when "make install" gtk-update-icon-cache: Cache file created successfully. Not sure whether it's just a message or a real confirmation of the success. Anyway, if it's only because of required newer gnome-icon-theme, then I'm fine, but it doesn't make much sense, because we ship that icons, so that should not be a problem of the third-part package at all. From my point of view, at least.
Michael: Go ahead and commit the contact-editor patch (and announce it). The more stuff we can kill in the "art" directory the better.
Matthew: done in r35937.
I guess this can be closed then. Reopen if there's any outstanding issues.