After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466442 - amrnbenc has not properties to add header and select band mode
amrnbenc has not properties to add header and select band mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.6
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-14 01:51 UTC by Daniel Charles
Modified: 2007-09-19 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for header and band mode properties (5.02 KB, patch)
2007-08-14 01:53 UTC, Daniel Charles 		committed Details | Review

Description Daniel Charles 2007-08-14 01:51:42 UTC 
The amrnbenc plugin has no properties to add the '#!AMR\n'  or to select the band mode of operation among

MR475 = 0,
MR515,
MR59,
MR67,
MR74,
MR795,
MR102,
MR122,
MRDTX

The patch proposes a gboolean property to insert the header and an enum to choose the band mode of operation.
Comment 1 Daniel Charles 2007-08-14 01:53:35 UTC 
Created attachment 93615 [details] [review]
Patch for header and band mode properties
Comment 2 Wim Taymans 2007-08-16 14:50:51 UTC 
Applied and cleaned up the property part.

For the addition of the header I would prefer to have a separate muxer element (like there is a demuxer). The reason being that it would then become possible to add the header to an already encoded file without a header (like making a standalone file from AMR in a container).

        Patch by: Daniel Charles <dcharles at ti dot com>

        * ext/amrnb/amrnbenc.c: (gst_amrnbenc_bandmode_get_type),
        (gst_amrnbenc_set_property), (gst_amrnbenc_get_property),
        (gst_amrnbenc_base_init), (gst_amrnbenc_class_init),
        (gst_amrnbenc_chain), (gst_amrnbenc_state_change):
        * ext/amrnb/amrnbenc.h:
        Add property to select the BandMode of the AMR encoder.
        See #466442.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2007-08-17 06:49:29 UTC 
Daniel, in gst-plugin-bad we have amrwb plugin (similar to the nb one). Could this also get the band-mode?
Comment 4 Daniel Charles 2007-09-15 18:19:21 UTC 
(In reply to comment #3)
> Daniel, in gst-plugin-bad we have amrwb plugin (similar to the nb one). Could
> this also get the band-mode?
> 

Yes, I'm going to submit the patch today.
Comment 5 Daniel Charles 2007-09-15 20:31:37 UTC 
Bug 477306 submitted to address amrwb bandmode property
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-19 12:21:39 UTC 
Daniel, many thanks! Closing this now.