After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464366 - program including gst/gstbuffer.h does not compile with -pedantic
program including gst/gstbuffer.h does not compile with -pedantic
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-07 13:41 UTC by arenevier
Modified: 2007-08-07 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description arenevier 2007-08-07 13:41:55 UTC 
Hi,
in a software including streamer-0.10/gst/gstbuffer.c, and compiling with -pedantic option, compilation fails with following error:
/usr/include/gstreamer-0.10/gst/gstbuffer.h:359: error: comma at end of enumerator list

My gcc version is:
gcc (GCC) 4.1.3 20070718 (prerelease) (Debian 4.1.2-14))

modifying gstbuffer.h as follows, problem seems to disappear

@@ -356,7 +356,7 @@
 typedef enum {
   GST_BUFFER_COPY_FLAGS      = (1 << 0),
   GST_BUFFER_COPY_TIMESTAMPS = (1 << 1),
-  GST_BUFFER_COPY_CAPS       = (1 << 2)
+  GST_BUFFER_COPY_CAPS       = (1 << 2),
 } GstBufferCopyFlags;
Comment 1 arenevier 2007-08-07 13:43:11 UTC 
oups, the diff I send was reverse :(

the real diff is :

@@ -356,7 +356,7 @@
 typedef enum {
   GST_BUFFER_COPY_FLAGS      = (1 << 0),
   GST_BUFFER_COPY_TIMESTAMPS = (1 << 1),
-  GST_BUFFER_COPY_CAPS       = (1 << 2),
+  GST_BUFFER_COPY_CAPS       = (1 << 2)
 } GstBufferCopyFlags;
 
 /**
Comment 2 Wim Taymans 2007-08-07 14:04:14 UTC 
        Patch by: <arenevier at fdn dot fr>

        * gst/gstbuffer.h:
        Remove comma from last element in enum to avoid compile errors when
        using -pendantic. Fixes #464366.