After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 46368 - [PATCH] Multibyte font handling
[PATCH] Multibyte font handling
Status: VERIFIED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Ramiro Estrugo
Nautilus Maintainers
: 46428 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2001-02-06 06:31 UTC by Eungkyu Song
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is my patch (14.75 KB, patch)
2001-09-10 00:59 UTC, Eungkyu Song
none Details | Review

Description Eungkyu Song 2001-09-10 00:59:02 UTC
In non-smooth mode, user can select only four types of font, helvetica, times,
courier, lucida. But, some language (CJK) need to use two or more fonts,
fontset. So, I make this patch to see Korean in nautilus.

This patch is to handle fontset. I fixed some function to handle fontset using
comma separated fontname (eg, use "helvetica,gulim" instead of "helvetica"). If
you edit po file, you can use this fontname. Seeing this patch to understand easily.

I think using po file to choose fontname is not so good method. Finally,
Preference should change to select many fonts.

Patch method:
1. patch this file
2. edit po file to use fontset
 (this patch include ko.po patch. this will be the example)
3. If patched nautilus crash in starting, please delete ~/.gconf and try again.

To do to be more i18n program.
1. fix functions in mozilla-scalable-font.c to handle fontset
 (I couldn't make patch of this because font rendering method is far different
and difficult to understand)
2. fix preference to select many fonts. (instead of using po file)
 (This is hard to me because I'm not good at gtk programming)



------- Additional Comments From eungkyu@sparcs.kaist.ac.kr 2001-02-06 01:32:28 ----

Created an attachment (id=1182)
This is my patch




------- Additional Comments From eungkyu@sparcs.kaist.ac.kr 2001-02-06 01:34:22 ----

I also change font size because it is too small to see in CJK language.



------- Additional Comments From sullivan@eazel.com 2001-02-06 09:04:37 ----

Leaving for Don to assign priority.



------- Additional Comments From eungkyu@sparcs.kaist.ac.kr 2001-02-06 10:25:27 ----

There is typo in my first comment.

mozilla-scalable-font.c -> nautilus-scalable-font.c




------- Additional Comments From don@eazel.com 2001-02-14 10:46:50 ----

Ramiro, will this help with the other work we're doing for distro friends?




------- Additional Comments From ramiro@fateware.com 2001-02-16 10:37:40 ----

*** Bug 46428 has been marked as a duplicate of this bug. ***



------- Additional Comments From don@eazel.com 2001-02-20 08:37:43 ----

Re-summarized from bug #46428.

Ramiro has a patch from Red Hat Japan for multibyte font handling support in
Nautilus.  That patch needs to be revised, integrated, and tested.




------- Additional Comments From eungkyu@sparcs.kaist.ac.kr 2001-02-22 03:49:47 ----

Where can I get Ramiro's patch? I want to find the difference from my patch.



------- Additional Comments From ramiro@fateware.com 2001-02-23 06:53:01 ----

Actually, there is no other patch!

There is a patch for getting the smooth fonts case to work.  Its a very tiny
patch for librsvg.

Im currently working on integrating your patch into Nautilus.  I think the
general idea of your patch is ok.  That is, localizing the font for each
locale.  I agree with you this isnt the best possible way to do this, but it
works.

There are a few issues with the patch that im working on right now.  Mostly
having to do with robustness.  You should see this make it into Nautilus very
soon.  

Thanks.




------- Additional Comments From darin@bentspoon.com 2001-02-28 15:05:51 ----

*** Bug 47134 has been marked as a duplicate of this bug. ***



------- Additional Comments From ramiro@fateware.com 2001-02-28 16:34:19 ----

fixed



------- Additional Comments From ramiro@fateware.com 2001-02-28 17:12:05 ----

Sorry, marked the wrong bug fixed.



------- Additional Comments From don@eazel.com 2001-03-04 22:19:04 ----

Ramiro, what's the status on this one?




------- Additional Comments From ramiro@fateware.com 2001-03-05 00:21:16 ----

Im done with the code changes.  They work fine in the ja locale.  Im not testing
the ko locale and will probably try a few others.

Ill file bugs for issues specific to each locale.

Marking this fixed.



------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:59 -------