After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 463255 - drop libgnome dep in libgnomekbdui
drop libgnome dep in libgnomekbdui
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Indicator
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2007-08-03 21:10 UTC by Jani Monoses
Modified: 2007-08-30 20:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
the patch (2.21 KB, patch)
2007-08-03 21:10 UTC, Jani Monoses
none Details | Review
finish the previous task by removing libgome refs from the build (2.60 KB, patch)
2007-08-05 19:18 UTC, Jani Monoses
none Details | Review
remove configure checks for libgnome libgnomeui (555 bytes, patch)
2007-08-27 12:23 UTC, Florian Steinel
none Details | Review

Description Jani Monoses 2007-08-03 21:10:19 UTC
replace gnome_program_init with gtk_init in the test program, and replaces
gnome_program_locate_file with DATADIR as it results from autoconf.

This should get rid of libgnomekbdui's dependency on libgnomeui which in turn helps apps that depend on libgnomekbdui (ex: screensaver)
Comment 1 Jani Monoses 2007-08-03 21:10:47 UTC
Created attachment 93061 [details] [review]
the patch
Comment 2 Sergey V. Udaltsov 2007-08-05 17:55:24 UTC
I also fixed Makefile.am files. Thanks for a bit of cleanup
Comment 3 Jani Monoses 2007-08-05 19:18:01 UTC
Created attachment 93113 [details] [review]
finish the previous task by removing libgome refs from the build

make libgnomekbd(ui) no longer pul libgnome in when linking.

now only the capplet needs those but since it relies on bonobo there's not much use to clean that of libgnome at this point.
Comment 4 Jani Monoses 2007-08-05 19:19:21 UTC
btw, is current trunk going to be part of GNOME 2.20?
Comment 5 Sergey V. Udaltsov 2007-08-12 17:46:23 UTC
I think yes. At least that's my plan.
Comment 6 Jani Monoses 2007-08-12 18:20:22 UTC
please look at the rest of the patch as well :) Should I have opened a new bug with it?
Comment 7 Sergey V. Udaltsov 2007-08-12 19:55:37 UTC
Please check Subversion - it is there, isn't it?
Comment 8 Jani Monoses 2007-08-13 06:49:02 UTC
I do not see the patch from comment #3 checked in, unless you started a new svn branch...  the pkgconfig files and the makefile.am-s still contain libgnome references.
Comment 9 Sergey V. Udaltsov 2007-08-20 20:31:10 UTC
Shame on me, I forgot to commit (though the patch was applied a while ago). Sorry.
Comment 10 Florian Steinel 2007-08-27 12:23:44 UTC
Created attachment 94422 [details] [review]
remove configure checks for libgnome libgnomeui

Remove checks in configure.in
Comment 11 Jani Monoses 2007-08-27 12:38:37 UTC
I think those are still required to build the capplet that's in the same tree.
Comment 12 Sergey V. Udaltsov 2007-08-27 17:01:38 UTC
Florian, Jani is right. I would not be able to build the capplet without libgnome* stuff.
Comment 13 Jani Monoses 2007-08-29 07:49:47 UTC
the last part of the patch in comment 3 was not commited. libgnomekbd/Makefile.am still has LIBGNOME_CFLAGS and LIBGNOME_LIBS so the whole package keeps pulling in libgome and bonobo
Comment 14 Sergey V. Udaltsov 2007-08-30 20:44:43 UTC
yes, libgnomekbd itself does not need that stuff. Committed, thanks.