After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462734 - Fix "Force Quit" dialog with non-UTF8 locale
Fix "Force Quit" dialog with non-UTF8 locale
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-08-02 09:55 UTC by Frederic Crozat
Modified: 2007-08-03 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
encode window title to locale encoding for metacity-dialog (1.07 KB, patch)
2007-08-02 09:56 UTC, Frederic Crozat
committed Details | Review

Description Frederic Crozat 2007-08-02 09:55:25 UTC
Since the switch to g_option, when used with non-UTF8 locale, "Force Quit" dialog mangles window names which are not ASCII. This is because g_option is calling g_locale_to_utf8 on every string parameter.

Attached patch fixes this issue by encoding window title to locale encoding for metacity-dialog call.
Comment 1 Frederic Crozat 2007-08-02 09:56:19 UTC
Created attachment 92904 [details] [review]
encode window title to locale encoding for metacity-dialog
Comment 2 Frederic Crozat 2007-08-02 17:13:56 UTC
for the record, I'm seeing it with fr_FR.ISO-8859-1
Comment 3 Elijah Newren 2007-08-03 03:09:24 UTC
Looks simple enough, and I though I can't test I'm going to assume you have.  Thanks, Frederic!
Comment 4 Frederic Crozat 2007-08-03 07:45:43 UTC
committed on HEAD.

2007-08-03  Frederic Crozat  <fcrozat@mandriva.com>

        * src/delete.c: Fix mangled window title in "Force Quit"
        dialog when using non-UTF8 locale. Close #462734.