GNOME Bugzilla – Bug 461944
pressing the volume icon in full screen shuts down the sound
Last modified: 2009-11-20 02:25:15 UTC
Hi, When running totem in fullscreen, if I press the volume button to make the slider appear, the slider goes at the bottom because of the mouse pointer and so the volume is shut down.
Which version of Totem?
oups sorry, 2.19.6
Yeah, you're supposed to click-drag the sound. Otherwise, it would be outside the screen, or we'd need to make the cursor jump. If anyone else has a better idea...
Function of icon button of sound idem to function of icon of button of youtube. == Spanish == Si el método del botón trabajara de la misma manera que el método del boton de youtube sería genial!!!. : -) ¿Qué falta? * Que la barra se abriera siempre en el mismo lugar. * El scroll no sea sensible a la posición del puntero del mouse. Este bug tambien esta en launchpad.net https://bugs.edge.launchpad.net/ubuntu/+source/totem/+bug/137041 Saludos!
*** Bug 504161 has been marked as a duplicate of this bug. ***
(In reply to comment #3) > Yeah, you're supposed to click-drag the sound. Otherwise, it would be outside > the screen, or we'd need to make the cursor jump. If anyone else has a better > idea... Here's a better idea: When the volume button is clicked, the slider opens, but without changing the current volume. That is, only display the control but don't change its value on a simple click, and ignore the rule that the cursor should be positioned over the currently selected spot on the slider. That, or make the cursor jump. Either way is acceptable, but having the movie you're watching become muted just by clicking the volume button is not.
"Yeah, you're supposed to click-drag the sound". Bastien, that's broken behaviour. Normal volume widgets have that option, but they also let you just click them to get the volume bar. Here, clicking the widget mutes the sound. As for dragging it? It mutes the sound too, until you drag it back up. There's no reason to completely mute the volume when you just want to change it a bit. I think there are two options to fix this problem: -Get back the previous volume bar - where the volume was not shown and controlled by a widget, but an horizontal bar. -Make the fullscreen volume widget work EXACTLY like the volume applet. That's: 1 click brings up the volume bar, then you can drag it.
*** Bug 526880 has been marked as a duplicate of this bug. ***
Created attachment 108914 [details] [review] gtk-dont-set-scale-to-zero.patch Please test this patch. It should send the first click to the volume button if the popup was moved (usually, the current position of the slider is straight under the mouse, as you can see in windowed mode).
*** Bug 532115 has been marked as a duplicate of this bug. ***
The volume applet is cumbersome because it requires the user to position the pointer precisely over the slider. It would be more intelligent to move the pointer to the current volume position while the slider is shown, and bring it back to the original position when it hides again. This should not be hard to implement -- just remember the position of the pointer, and move the pointer twice. I think I will post a bug for the volume applet too. The approach in the patch makes the volume control modal -- the behavior depends on the window's position in relation to the screen edge. That would be surprising and annoying to users.
This bug is still present in version 2.24
That would be because nobody tested the patch...
What is the way to proceed to test the patch ? I don't know what to do with the attachment.
This doesn't only happen when a program is Maximized/Full-Screened. Even if the Volume Slider has enough space on the screen, and the mouse isn't moved at all, clicking the volume button changes the volume by 2-3%. When a program like Totem, Banshee, Rhythmbox, etc is Full-Screened or Maximized, it is simply more drastic. If the button is at the top of the screen and volume is low, it changes to high. If the button is at the bottom of the screen, and volume is high, it changes it to very low or mute. It would be nice to see the Volume Slider not appear until Click Release. It would also be nice to see the volume slider appear either below the button or above the button, depending on space/placement. A Drawer effect would be nice (Panel Drawers/YouTube volume control). Percentage shown would also be nice (Bug 440131). But it shouldn't appear over top of the button you're clicking, or change unexpectedly. Also, I think these are Duplicates: Bug 540669 Bug 460733 Bug 327149 Thanks! - Darin
"It would be nice to see the Volume Slider not appear until Click Release" With that I disagree. Being able to set the volume with just one mouse click is one of my favourite thing in Gnome media players. Maybe make it not appear until click release if (and only if) it detects that it would collide with a screen border.
*** Bug 561864 has been marked as a duplicate of this bug. ***
*** Bug 540669 has been marked as a duplicate of this bug. ***
Created attachment 132354 [details] [review] patch to fix setting volume to zero
Patch working, but i applied him manually, because gtkscalebutton.c has changed in gtk+-2.14.4. Tested in gnome-mplayer and totem in fullscreen mode. All looks good. actual patch in attach.
hey... anyone there? Please, commit patch
Hi guys, I just upgrade my Fedora to the 11 version hoping this annoying bug will be gone. I run Totem 2.26.2 with Gstreamer 0.10.22 and the issue is present. I don't get the fact the bug as a UNCONFIRMED status as it is pretty easy to reproduce. Any news from this?
(In reply to comment #22) > I run Totem 2.26.2 with Gstreamer 0.10.22 and the issue is present. > I don't get the fact the bug as a UNCONFIRMED status as it is pretty easy to > reproduce. The status doesn't mean anything, it's bugzilla book-keeping. > Any news from this? Read the bug, and try the patch.
I've applied the patch from Evgeny to gtk+2.0_2.16.1-0ubuntu2 (Ubuntu Jaunty) and is works well. Singe click opens the slider now instead of doing a click-and-drag.
The reason why the patch is so long compared to the one I submitted is because you made unwarranted changes to the identation.
Created attachment 137183 [details] [review] 0001-Bug-461944-pressing-the-volume-icon-in-full-scre.patch Updated patch for current master.
Fixed in master and gtk-2-16 commit b436f5b8a3c8ad0468d2420895fa97dc7c711969 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jun 22 17:19:21 2009 +0100 Bug 461944 – pressing the volume icon in full screen shuts down the sound Don't pass the click on the button through to the scale when the dock popup will be moved, otherwise we could end up changing the sound in unexcepted ways (to zero for vertical popups at the bottom of the screen for example).
Thank you so much to both of you for fixing this quite ridiculous bug that has been hitting us for too long! ;-)
*** Bug 584231 has been marked as a duplicate of this bug. ***
*** Bug 602340 has been marked as a duplicate of this bug. ***