After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461899 - configure doesn't find Xlib headers in non-standard locations
configure doesn't find Xlib headers in non-standard locations
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
2.18.x
Other All
: Normal minor
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2007-07-30 18:21 UTC by Dan Nicholson
Modified: 2007-08-01 20:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Find Xlib from AC_PATH_XTRA (1.03 KB, patch)
2007-07-30 18:25 UTC, Dan Nicholson 		none Details | Review

Description Dan Nicholson 2007-07-30 18:21:24 UTC 
Use standard autoconf techniques to find the host's X11 libraries and headers since libgnomekbd uses Xlib and XKB.

Other information:
The libgnomekbd configure process currently relies on finding the host's X11 installation implicitly through gdk-x11-2.0 and other pkg-config checks. However, these are not guaranteed to find the X11 headers. Also, libX11 only ends up being linked as NEEDED despite libgnomekbd using Xlib and XKB.
Comment 1 Dan Nicholson 2007-07-30 18:25:46 UTC 
Created attachment 92731 [details] [review]
Find Xlib from AC_PATH_XTRA

Attached patch uses AC_PATH_XTRA to find the host's X11 installation. This is only the minimal setup. Really, it should also check for <X11/XKBlib.h> or <X11/extensions/XKBgeom.h> since they're used in gkbd-drawing.h.

The above check was taken from gtk+. It could alternatively try to find x11 and kbproto from pkg-config and then fall back to AC_PATH_XTRA.
Comment 2 Sergey V. Udaltsov 2007-08-01 20:48:53 UTC 
Well spotted, thanks, committed.