After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461658 - Hue-Saturation tool with gradients
Hue-Saturation tool with gradients
Status: RESOLVED INCOMPLETE
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-07-30 02:31 UTC by Marius Bieliauskas
Modified: 2009-02-05 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This adds two gradient bars in hue-saturation tool dialog (9.70 KB, patch)
2007-07-30 02:33 UTC, Marius Bieliauskas
none Details | Review
A mockup of Hue-Saturation tool dialog (139.54 KB, image/jpeg)
2007-07-30 19:10 UTC, Marius Bieliauskas
  Details

Description Marius Bieliauskas 2007-07-30 02:31:36 UTC
Currently, hue-saturation tool dialog has master button surrounded with 6 color boxes, whitch changes its color while regulating hue/lightness/saturation values. Unfortunately it makes this dialog unnesasary big. 

So my enhancement proposal would be to make this dialog look more like photoshop`s, but of course, not identical. In my opinion, those two hsl gradients can show quite alot information, even without looking at the modified picture itself. Most important, you can see seamless color transitions, and compare to the original gradient.

As a start, I just added those two gradients, without radicaly changing this meniu.

I should mention, that I encountered a problem with current svn version, that gimp_gradient_get_color_at function now requires gimpcontext, thou it is absolutely unnecessary in this case, so I dont know how to get it, and for now, I just made it optional in there.
Comment 1 Marius Bieliauskas 2007-07-30 02:33:26 UTC
Created attachment 92670 [details] [review]
This adds two gradient bars in hue-saturation tool dialog
Comment 2 Sven Neumann 2007-07-30 06:40:51 UTC
Thanks for your contribution. But instead of posting code, perhaps you should first post a mockup and a detailed description of what you actually want to achieve and why. And you should post this on the gimp-developer list before opening a bug report for it.
Comment 3 Marius Bieliauskas 2007-07-30 19:10:53 UTC
Created attachment 92732 [details]
A mockup of Hue-Saturation tool dialog
Comment 4 Sven Neumann 2007-07-30 19:28:41 UTC
Please discuss this on the mailing-list. It is too late to accept this for GIMP 2.4 anyway so we can take our time to discuss how this tool could be improved.
Comment 5 Marius Bieliauskas 2007-07-30 19:38:02 UTC
Sorry, I have never done this before, thats my very first attempt to
participate in open source project.
And thank you for reminding me about the mockup. I realy had to do this in the
first place.
Comment 6 Sven Neumann 2007-07-30 21:20:24 UTC
Your contribution is appreciated. But please understand that user interface changes should be presented to a larger audience and discussed before an enhancement request is filed for it.
Comment 7 Marius Bieliauskas 2007-07-30 21:59:42 UTC
I do understand that, thats why I`m trying to discus this matter.
Comment 8 Sven Neumann 2007-08-03 13:54:36 UTC
So far the only reason given for this change was that the dialog would be too big. Given the fact that with the suggested changes it doesn't become much smaller but IMO a more difficult to work with, there doesn't seem to be much point in this proposal. Setting to NEEDINFO until the discussion on the mailing-list has yield a result.
Comment 9 Jakub Friedl 2007-08-14 21:35:12 UTC
I have to say that I like the proposed change. I find the current dialog somewhat confusing - you have to compare color name (or just a one-letter acronym to be precise) with a patch of color. That is not natural for (at least my) brain. (Working with this dialog reminds me of this optical "illusion": http://www.illusion-optical.com/Optical-Illusions/ColorReading.php )

The proposed mockup compares colors with colors - that is much easier for my brain. And it gives way better idea about the color shift.

I also like the ability to set the overlap. It gives really good control over the color shift - I am missing this control often when working with this tool).
Comment 10 Jakub Friedl 2007-08-14 21:39:35 UTC
Also "Master" is somewhat confusing. I would propose changing that to  "All colors" or something similar.
Comment 11 Sven Neumann 2007-08-14 22:02:52 UTC
The overlap option was added almost two years ago already (bug #166628).
Comment 12 Jakub Friedl 2007-08-15 13:34:33 UTC
Oops, i haven't noticed the overlap option. It is not yet in my production 2.2 version. Time to upgrade to 2.4 i think. Anyway, the main point was to point out that visually comparing color to color instead of comparing color to text is a good idea.
Comment 13 Michael Schumacher 2007-12-04 22:27:41 UTC
Has this been discussed on the mailing list yet?
Comment 14 Tobias Mueller 2009-02-05 19:39:36 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!