GNOME Bugzilla – Bug 461620
Orca doesn't speak find results in FF3 when focus is on Next/Previous buttons
Last modified: 2008-07-22 19:28:17 UTC
When the Find toolbar support was added to Orca, the Next and Previous buttons on the Firefox Find toolbar were not in the tab order, necessitating the user press Enter/Alt N for Next and Alt P for Previous. These buttons are now in the tab order, but we're not speaking the matches when focus is on these buttons like we do when focus is in the Find entry. We should be. :-) Thanks MIke for pointing this out!
Created attachment 92662 [details] [review] proposed patch Check to see if the locusOfFocus is in an entry *or* on a push button inside a toolbar when deciding on whether or not we should be announcing the changing contents of the screen. Mike please test. Thanks!
Works great. thanks much
Thanks Mike. This being a bug fix I committed it to both the 2.20 branch and trunk. Moving to pending.
I've recently found a new problem with the find feature that may be related to this fix. To reproduce, do the following: 1. With orca running open the latest FF nightly. 2. Do a find and then press escape when orca speaks what you have found. 3. Press CTRL+f to attempt another find. What you should find is that the first time find is attempted the find dialog is spoken as expected. You should also find that orca speaks nothing for any subsequent find attempts for the current session of firefox. If you close firefox and re-open it you should find that orca will speak the find dialog for the first find attempt for the new firefox session but any further attempts will yield no speech.
That issue seems to come and go. Did you try reversing the patch and trying again to reproduce the problem? When I reversed the patch, I could still reproduce the problem. All the patch does is say "are we on a button or in an entry?" instead of "are we in an entry?" I would that that should be irrelevant to the problem you report. In addition, please see this bug I filed last month: https://bugzilla.mozilla.org/show_bug.cgi?id=385070: A defunct instance of the Find toolbar can claim to have focus via AT-SPI. If you start Orca from gnome-terminal, get to where you can reproduce the problem, and -- from within that entry, press Orca_Modifier+F7 to dump out the ancestry, I suspect you will see something like this: +-name='Minefield' role='application' state='' relations='' +-name='Bug 461620 - [pending] Orca doesn't speak find results in FF3 when focus is on Next/Previous buttons (orca) - Minefield' role='frame' state='ACTIVE ENABLED RESIZABLE SENSITIVE SHOWING VISIBLE' relations='EMBEDS' +-name=None role='invalid' state='DEFUNCT' relations='' +-name='Find:' role='entry' state='EDITABLE ENABLED FOCUSABLE FOCUSED HORIZONTAL OPAQUE SENSITIVE SHOWING SINGLE_LINE VISIBLE' relations='LABELLED_BY' Note that the parent of the Find: entry is not a toolbar, but has ROLE_INVALID, and STATE_DEFUNCT.
When I first rolled back the patch I didn't see the problem but as this problem doesn't seem to be 100% reproducible that was probably a coincidence. Some times I can now reproduce the problem both with and without the patch. This bug is probably OK to close as fixed.
I hate intermittent bugs. Anyhoo, closing as FIXED. If we find bugs related to the patch we can of course reopen it.