Created attachment 92661 [details] [review]
patch

it might be a bit risky to commit this, gtkstyle.c also hardcodes g_free in                                                option_menu_get_props(). if the same habbit got copied iunto user code, we'll be causing a lot of hard to catch crashers.

Created attachment 93751 [details] [review]
updated patch, fixes gtkstyle.c too

It's a bit risky, yes. OTOH the gtkborder change (bug 383557) broke only a few programmes, and GtkRequistion is used even less (only in option menu, afaik). Since we done, have the gtkborder change, I think this change should be ok to do in the same release (2.12) ?

May I commit at least the parts of this patch that make gtkoptionmenu.c and gtkstyle.c use the correct free function ?

Yes, that part is fine to remove once the hard code freeze lifts.

(In reply to comment #4)
> May I commit at least the parts of this patch that make gtkoptionmenu.c and
> gtkstyle.c use the correct free function ?

commited in commit 0983017630594f6d34db09f942a012c2b1a4e48f


How about the rest of the patch?

Created attachment 160240 [details] [review]
Use GSlice for gtkrequisition

Updated patch against current master.

Also, added gtk_requisition_new to avoid memory allocator confusions when
using GtkRequisitions.

Created attachment 162147 [details] [review]
Use GSlice for gtkrequisition.v2

Fix a typo in previous patch

Review of attachment 162147 [details] [review]:

looks good

Comment on attachment 162147 [details] [review]
Use GSlice for gtkrequisition.v2

commit eaab96c066b550445df1883b2fe8728d61f42b99

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.