After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 458746 - [will] flat-review does not review current item in Java HTML text
[will] flat-review does not review current item in Java HTML text
Status: RESOLVED WONTFIX
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Lynn Monsanto
Orca Maintainers
Depends on:
Blocks: orca-java
 
 
Reported: 2007-07-20 19:00 UTC by Lynn Monsanto
Modified: 2007-07-26 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.02 KB, patch)
2007-07-24 17:59 UTC, Lynn Monsanto
none Details | Review

Description Lynn Monsanto 2007-07-20 19:00:55 UTC
flat-review does not review current item in Java HTML text. Launch the jedit installer, which displays a HTML document in a viewport. KP-5 does not review the current item, although KP-4 and KP-6 review the previous and next items.
Comment 1 Lynn Monsanto 2007-07-23 17:43:52 UTC
I added a bunch of debug statements and found that speech.speak is being call correctly with the right string to speak. orca.gnomespeechfactory.SpeechServer is called on speech.py line 160, but no speech is spoken. Review current line and current character works, just not review current item. Any suggestions?
Comment 2 Willie Walker 2007-07-23 19:25:53 UTC
(In reply to comment #1)
> I added a bunch of debug statements and found that speech.speak is being call
> correctly with the right string to speak. orca.gnomespeechfactory.SpeechServer
> is called on speech.py line 160, but no speech is spoken. Review current line
> and current character works, just not review current item. Any suggestions?
> 

Strange.  :-(  What text is being passed to the speak method?  In addition, is the debug rectangle being painted for the current review item when you hit KP_5?
Comment 3 Lynn Monsanto 2007-07-23 23:43:58 UTC
The text passed to the speechserver.speak method is the current item text. For example, when the current text item is "Simply" and I press KP-5, the speech output should be "Simply". 

_reviewCurrentItem
  index=1
  word=Simply [763 505 46 17]
  context=Simply [763 505 46 17]
adjustForRepeats: line='Simply', segment='y', newLine='Simpl'
SPEECH OUTPUT: 'Simply'
_speechserver=<orca.gnomespeechfactory.SpeechServer object at 0x8535a0c>

Everything looks ok, except that I don't hear the text when speechserver.speak is called. Also, the rectangle is drawn correctly around the current item.
Comment 4 Willie Walker 2007-07-24 12:35:23 UTC
(In reply to comment #3)
> The text passed to the speechserver.speak method is the current item text. For
> example, when the current text item is "Simply" and I press KP-5, the speech
> output should be "Simply". 
> 
> _reviewCurrentItem
>   index=1
>   word=Simply [763 505 46 17]
>   context=Simply [763 505 46 17]
> adjustForRepeats: line='Simply', segment='y', newLine='Simpl'
> SPEECH OUTPUT: 'Simply'
> _speechserver=<orca.gnomespeechfactory.SpeechServer object at 0x8535a0c>
> 
> Everything looks ok, except that I don't hear the text when speechserver.speak
> is called. Also, the rectangle is drawn correctly around the current item.

I wonder if something might be causing the speech to stop.  Can you dig around in this area and see if this is happening?
Comment 5 Lynn Monsanto 2007-07-24 17:54:21 UTC
I misinterpreted the debug.out statements and thought the output in Comment #3 was the result of pressing KP-5. Instead, it was the result of previously pressing KP-6. My Microsoft Natural Keyboard Elite generates a "Begin" event when KP-5 is pressed, which has no mapping to an input event handler. The solution is to add a mapping for "Begin" to the same imput event handler as KP-5 and KP-Begin.
Comment 6 Lynn Monsanto 2007-07-24 17:59:13 UTC
Created attachment 92295 [details] [review]
proposed patch
Comment 7 Willie Walker 2007-07-24 18:06:06 UTC
> I misinterpreted the debug.out statements and thought the output in Comment #3
> was the result of pressing KP-5. Instead, it was the result of previously
> pressing KP-6. My Microsoft Natural Keyboard Elite generates a "Begin" event
> when KP-5 is pressed, which has no mapping to an input event handler. The
> solution is to add a mapping for "Begin" to the same imput event handler as
> KP-5 and KP-Begin.

Ah...very strange.  Is your NumLock key locked?  In addition, when you do a "xmodmap -pk | grep -i begin", what do you get?
Comment 8 Lynn Monsanto 2007-07-26 16:30:48 UTC
This bug will not be fixed since mapping the Begin key to an Orca action would interfere with the normal use of the Begin key.