After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 456903 - Opening results with xdg broken
Opening results with xdg broken
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Search Tool
unspecified
Other All
: Normal normal
: ---
Assigned To: Jamie McCracken
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2007-07-14 16:48 UTC by David Förster
Modified: 2007-07-21 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
attempts to fix xdg-open brokenness (1.49 KB, patch)
2007-07-17 15:45 UTC, Tshepang Lekhonkhobe
none Details | Review
another attempt to fix xdg-open brokenness (1.09 KB, patch)
2007-07-17 17:10 UTC, Tshepang Lekhonkhobe
none Details | Review

Description David Förster 2007-07-14 16:48:41 UTC
Please describe the problem:
The logic to use xdg-open to open a search result when clicked is completely broken. (See open_file_cb()).

xdg-open is only used when open_file_with_application() fails and the element is a directory.


Steps to reproduce:
On my KDE Desktop: Search for a PDF file and double click it.

Actual results:
It's opened with xpdf because that seems to be the registered application for PDF files in the gnome database. (I don't use Gnome.)

Expected results:
It should be opened with KPDF as this is the application that gets started when I execute "xdg-open file.pdf" manually.

Does this happen every time?
Yes.

Other information:
There's also a report in the debian bugtracker: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=415705
Comment 1 Tshepang Lekhonkhobe 2007-07-17 15:45:58 UTC
Created attachment 91897 [details] [review]
attempts to fix xdg-open brokenness
Comment 2 Jamie McCracken 2007-07-17 16:09:26 UTC
needs to be changed slightly

if its a folder then it works ok with xdg-open

if xdg-open is not present then it looks like it fail.

Suggest using gnome-open as a fallback for directories (non-gnome users will have to make sure they have xdg-open installed)
Comment 3 Tshepang Lekhonkhobe 2007-07-17 17:10:05 UTC
Created attachment 91900 [details] [review]
another attempt to fix xdg-open brokenness
Comment 4 Jamie McCracken 2007-07-21 22:47:06 UTC
Fixed in svn with quite a bit of modification to your patch