After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 455354 - problems with JInternalFrames
problems with JInternalFrames
Status: RESOLVED DUPLICATE of bug 458142
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Lynn Monsanto
Orca Maintainers
Depends on:
Blocks: orca-java
 
 
Reported: 2007-07-09 23:36 UTC by Lynn Monsanto
Modified: 2007-07-25 17:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
potential patch (2.64 KB, patch)
2007-07-13 02:26 UTC, Lynn Monsanto
needs-work Details | Review
potential patch (611 bytes, patch)
2007-07-16 21:18 UTC, Lynn Monsanto
none Details | Review

Description Lynn Monsanto 2007-07-09 23:36:36 UTC
Flat-review does not recognize the JInternalFrames in the SwingSet2 JInternalFrame demo. Orca speaks the JInternalFrame slider thumbs, but nothing else.
Comment 1 Lynn Monsanto 2007-07-12 16:45:06 UTC
This is a more general problem. Orca just speaks 'scroll pane' when an internal frame gets keyboard focus.
Comment 2 Lynn Monsanto 2007-07-12 18:47:37 UTC
Correction: Orca speaks 'scroll pane' only if the internal frame is empty. Otherwise, Orca speaks the component that has focus in the internal frame that has focus.

Question: What is the correct behavior when a different internal frame first gets focus?

Control-F6 is used to navigate among the internal frames in a window. Tab is used to navigate among the components in the internal frame that has focus.

Right now, Orca just speaks the component that got focus in the internal frame that got focus. I propose that when a different internal frame first gets focus, Orca should speak the name of the internal frame followed by the name of the component in the internal frame that got focus. Otherwise, the user has no indication that she is navigating inside a different internal frame.
Comment 3 Mike Pedersen 2007-07-12 18:51:24 UTC
You probably should take a look at the panel and frame examples from the gtk-demo application for an example of how this is intended to work.
Comment 4 Lynn Monsanto 2007-07-13 02:18:07 UTC
Mike,

Would you be more explicit about the names of the demos I should look at. I could find anything like internal frames in the gtk-demo examples.

Thanks
Comment 5 Lynn Monsanto 2007-07-13 02:26:27 UTC
Created attachment 91712 [details] [review]
potential patch

Assuming proposal in Comment #2 is acceptable, the attached patch implements this behavior.
Comment 6 Willie Walker 2007-07-13 12:13:55 UTC
The typical way Orca handles the presentation of text associated with containers is via speechgenerator.py:getSpeechContext and braillegenerator.py:getBrailleContext.  For some reason, it seems like these might either not be getting called or they might be skipping JInternalFrames for some reason.  Can you take a look in this area of the code and see what's going on?
Comment 7 Lynn Monsanto 2007-07-16 21:18:19 UTC
Created attachment 91875 [details] [review]
potential patch

It appears that line 1658 in the speechgenerator.getSpeechContext method is too restrictive. The default.Script.getDisplayedText method may use the parent name if the parent text object is None. 

Orca speaks the JInternalFrame context correctly with this patch.
Comment 8 Willie Walker 2007-07-22 20:04:24 UTC
(In reply to comment #7)
> Created an attachment (id=91875) [edit]
> potential patch
> 
> It appears that line 1658 in the speechgenerator.getSpeechContext method is too
> restrictive. The default.Script.getDisplayedText method may use the parent name
> if the parent text object is None. 
> 
> Orca speaks the JInternalFrame context correctly with this patch.
> 

Definitely an interesting patch.  Is the root of the problem that JInternalFrame does not implement Accessible Text (seems like it should), and that it sets the Accessible name to the text being displayed?

See also http://bugzilla.gnome.org/show_bug.cgi?id=458142#c3 of bug 458142 for comments on this patch.  Thanks!
Comment 9 Lynn Monsanto 2007-07-25 17:38:45 UTC

*** This bug has been marked as a duplicate of 458142 ***