After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 454710 - Wrap new Glib::OptionContext API that was added in glib 2.12
Wrap new Glib::OptionContext API that was added in glib 2.12
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: general
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2007-07-08 00:09 UTC by Jonathon Jongsma
Modified: 2007-07-09 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wrap new OptionContext API (362.24 KB, patch)
2007-07-08 00:09 UTC, Jonathon Jongsma
committed Details | Review

Description Jonathon Jongsma 2007-07-08 00:09:04 UTC
From the ChangeLog:

2007-07-07  Jonathon Jongsma  <jjongsma@gnome.org>

	* glib/src/optioncontext.ccg:
	* glib/src/optioncontext.hg: add some new API that was added in glib 2.12,
	including get/set_summary(), get/set_description(), set_translation_domain(),
	and set_translate_fun().
	* glib/src/glib_docs.xml: Regenerated with docextract_to_xml.py
	* glib/src/glib_docs_override.xml: override docs for the new functions so
	that they say that they were introduced in glibmm 2.14 instead of 2.12

Patch attached...  

I'd appreciate some review on the set_translate_func() function in particular, since that one involves more than a simple gmmproc wrapper.  I based it on the cellrenderer set_cell_data_func() function.
Comment 1 Jonathon Jongsma 2007-07-08 00:09:52 UTC
Created attachment 91383 [details] [review]
wrap new OptionContext API
Comment 2 Murray Cumming 2007-07-09 13:17:15 UTC
It looks fine. Please commit.
Comment 3 Jonathon Jongsma 2007-07-09 13:37:19 UTC
Thanks for the quick review.  committed.