After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451856 - make volume property a double instead of int
make volume property a double instead of int
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 450635 451866
Blocks:
 
 
Reported: 2007-06-28 12:45 UTC by Christian Persch
Modified: 2007-06-28 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (20.96 KB, patch)
2007-06-28 12:46 UTC, Christian Persch 		needs-work Details | Review
updated patch (14.45 KB, patch)
2007-06-28 16:32 UTC, Christian Persch 		accepted-commit_now Details | Review

Description Christian Persch 2007-06-28 12:45:08 UTC 
The bacon-vide-widget's "volume" property is currently an integer with the range 0..100. But the underlying gstreamer element's volume is double with range 0..1; I think this should just be exposed like that. This is also important for the browser plugin since the volume range the scriptables expose to the browser vary:  GMP is 0..100 while narrowspace uses 0..255.
Comment 1 Christian Persch 2007-06-28 12:46:17 UTC 
Created attachment 90800 [details] [review]
proposed patch
Comment 2 Bastien Nocera 2007-06-28 12:48:49 UTC 
It collides with the work being done in bug 450635 (Jens' patch to remove the bacon volume widget), and the xine backend would need to be modified as well.
Comment 3 Christian Persch 2007-06-28 12:58:03 UTC 
The patch does modify bvw-xine.c too.
Comment 4 Christian Persch 2007-06-28 16:32:17 UTC 
Created attachment 90810 [details] [review]
updated patch
Comment 5 Bastien Nocera 2007-06-28 16:49:18 UTC 
Looks good, please commit.
Comment 6 Christian Persch 2007-06-28 17:31:46 UTC 
        * src/totem.c:
        * src/totem.h:
        * src/totem-private.h:
        * src/backend/bacon-video-widget.h:
        * src/backend/bacon-video-widget-xine.c:
        * src/backend/bacon-video-widget-gst-0.10.c: Use double for the volume
        instead of integer. Bug #451856.