After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450786 - PATCH: Use themeable app icons
PATCH: Use themeable app icons
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-25 02:41 UTC by Michael Terry
Modified: 2007-06-26 23:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (4.80 KB, patch)
2007-06-25 02:41 UTC, Michael Terry 		none Details | Review

Description Michael Terry 2007-06-25 02:41:03 UTC 
Part of the AppIcon GnomeGoal (http://live.gnome.org/GnomeGoals/AppIcon).

The following patch installs the 48x48 icons in the hicolor theme and uses the correct gtk call to grab app icons from the theme, not .../pixmaps.

One odd thing I noticed is that the gdmphotosetup .desktop file references the icon 'login-photo' but the actual application uses 'stock_person' as a window icon.  Also, 'login-photo' isn't very well namespaced (could be gdm-login-photo or some such).  But I left it as is, except to install it to the right place.
Comment 1 Michael Terry 2007-06-25 02:41:37 UTC 
Created attachment 90598 [details] [review]
Proposed patch
Comment 2 Brian Cameron 2007-06-25 03:10:43 UTC 
Thanks.  Committed to SVN head.  If you want to change the icon names to have better namespace, feel free.

Also, you might take a look at the patch in bug #360984.  This adds nifty new
icons to the gdmgreeter menu so that each menu item has a nice new icon.  The
patch mostly works, but I was never able to figure out how to properly install the icons.  If you understand how icons should be installed, this might not be so hard for you?
Comment 3 Michael Terry 2007-06-26 23:04:58 UTC 
Just a followup -- I moved gui/login-photo.png to a better location and name: pixmaps/48x48/gdm-login-photo.png.

I'll look at that bug.