After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 449274 - Application specific icons are installed in the wrong directory
Application specific icons are installed in the wrong directory
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-06-19 21:21 UTC by Jaap A. Haitsma
Modified: 2007-07-31 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch without the changes in the icons directory (11.02 KB, patch)
2007-07-31 04:41 UTC, Jaap A. Haitsma
none Details | Review
All the files below the icons directory (658.30 KB, application/x-gzip)
2007-07-31 04:44 UTC, Jaap A. Haitsma
  Details

Description Jaap A. Haitsma 2007-06-19 21:21:19 UTC
Now you install everything in ${prefix}/share/icons/hicolor/apps
You should only install the gnome-power-manager application icon overthere

The rest should be installed in

${prefix}/share/gnome-power-manager/icons/hicolor/<size>/<context>

See http://live.gnome.org/ThemableAppSpecificIcons
Comment 1 Richard Hughes 2007-06-25 21:50:55 UTC
I think they were moved out so the applets could use the icons, iirc. I'll have a look this weekend.
Comment 2 Jaap A. Haitsma 2007-07-31 04:41:08 UTC
Created attachment 92758 [details] [review]
patch without the changes in the icons directory
Comment 3 Jaap A. Haitsma 2007-07-31 04:44:53 UTC
Created attachment 92760 [details]
All the files below the icons directory

Since below the icon directory the files get moved a lot. I just put all the files below the icons directory in this tarball.

So in order to use the complete patch
1. Apply the patch of the previous attachment
2 [details]. replace the icons directory with this one

Richard, can I apply all this?
Comment 4 Richard Hughes 2007-07-31 07:35:32 UTC
>Richard, can I apply all this?

Sure, just be very careful. I would also prefer it if you did:

svn mv old_icon.png new_location/new_icon.png

just to keep the history where possible. Also, please check "make distcheck" still works. Thanks for doing this.

Richard.
Comment 5 Jaap A. Haitsma 2007-07-31 12:22:58 UTC
2007-07-31  Jaap Haitsma  <jaap@haitsma.org>

	* src/gpm-stock-icons.c: deleted not needed anymore
	* src/gpm-stock-icons.h: removed function prototypes

2007-07-31  Jaap Haitsma  <jaap@haitsma.org>

	* applets/brightness/GNOME_BrightnessApplet.server.in.in:
	* applets/brightness/Makefile.am:
	* applets/brightness/brightness-applet.c:
	(gpm_brightness_applet_init):
	* applets/inhibit/GNOME_InhibitApplet.server.in.in:
	* applets/inhibit/Makefile.am:
	* applets/inhibit/inhibit-applet.c: (gpm_inhibit_applet_init):
	* configure.in:
	* data/gnome-power-manager.desktop.in:
	* data/gnome-power-statistics.desktop.in:
	* data/icons/16x16/Makefile.am:
	* data/icons/16x16/actions/Makefile.am:
	* data/icons/16x16/apps/Makefile.am:
	* data/icons/16x16/status/Makefile.am:
	* data/icons/22x22/Makefile.am:
	* data/icons/22x22/actions/Makefile.am:
	* data/icons/22x22/apps/Makefile.am:
	* data/icons/22x22/status/Makefile.am:
	* data/icons/24x24/Makefile.am:
	* data/icons/24x24/actions/Makefile.am:
	* data/icons/24x24/apps/Makefile.am:
	* data/icons/24x24/status/Makefile.am:
	* data/icons/48x48/Makefile.am:
	* data/icons/48x48/actions/Makefile.am:
	* data/icons/48x48/apps/Makefile.am:
	* data/icons/48x48/status/Makefile.am:
	* data/icons/generate_24x24_icons.sh:
	* data/icons/generate_48x48_icons.sh:
	* data/icons/scalable/Makefile.am:
	* data/icons/scalable/actions/Makefile.am:
	* data/icons/scalable/apps/Makefile.am:
	* data/icons/scalable/apps/gnome-brightness-applet.svg:
	* data/icons/scalable/apps/gnome-inhibit-applet.svg:
	* data/icons/scalable/apps/gnome-power-manager.svg:
	* data/icons/scalable/gpm-brightness-kbd-disabled.svg:
	* data/icons/scalable/gpm-brightness-kbd-invalid.svg:
	* data/icons/scalable/gpm-brightness-lcd-disabled.svg:
	* data/icons/scalable/gpm-brightness-lcd-invalid.svg:
	* data/icons/scalable/gpm-inhibit-invalid.svg:
	* data/icons/scalable/gpm-phone-000.svg:
	* data/icons/scalable/gpm-phone-030.svg:
	* data/icons/scalable/gpm-phone-060.svg:
	* data/icons/scalable/gpm-phone-100.svg:
	* data/icons/scalable/status/Makefile.am:
	* src/Makefile.am:
	* src/gpm-main.c: (gpm_exit), (main):
	* src/gpm-stock-icons.c:
	* src/gpm-stock-icons.h:
	Use application specific icons in the recommended way. Fixes bug #449274