After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 44906 - Bookmark icon not updated immediately when new file created at bookmark's location
Bookmark icon not updated immediately when new file created at bookmark's loc...
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: Bookmarks
3.0.x
Other All
: Low minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 43218 446658 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2000-11-30 19:23 UTC by John Sullivan
Modified: 2017-09-04 17:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.91/3.0


Attachments
Proposed patch (1.29 KB, patch)
2006-01-06 20:40 UTC, Christian Neumair
committed Details | Review

Description John Sullivan 2001-09-10 00:48:40 UTC
To reproduce:
(1) Create a new folder, name it "bookmark test"
(2) Double-click it to visit.
(3) Choose "Add Bookmark" to add a bookmark for "bookmark test" to the Bookmarks
menu
(4) Hit Back
(5) Select "bookmark test" and select "Move to Trash"
(6) Empty trash.
(7) Pull down Bookmarks menu. Note that the icon for "bookmark test" is the
"missing bookmark" image, not the folder image (this is behaving correctly so
far)
(8) Create another new folder in the directory that used to contain "bookmark
test", name it "bookmark test"
(9) Pull down Bookmarks menu. Note that the icon for "bookmark test" is still
the "missing bookmark" image. 

In an ideal world this would now be the folder image, since the file once again
exists. Note that if you visit the new "bookmark test" by double-clicking, the
icon in the bookmarks menu will update. It will also update if you do anything
else that refreshes the menu, like adding a new bookmark or changing themes (or
quitting/restarting Nautilus). So the bug is just that there's a period of time
during which the icon has not yet updated.

This is a consequence of the fix I made for bug 44899.



------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:48 -------
Comment 1 John Fleck 2001-10-11 15:23:45 UTC
Verifying this. marking 'future'
Comment 2 David Kennedy 2002-11-01 20:29:03 UTC
Verified in 2.0.7 - bug still exists. 

There is another issues here - moving the directory to the trash
causes the bookmark to be updated with the trash location.

Barring that if we

1 - bookmark directory X
2 - remove directory X using the terminal
3 - create the directory X (using the terminal or nautilus)

The bookmark icon X stays "broken" instead of changing back a "folder"
icon. But if we then do any one of the following

* add another bookmark pointing to directory X
* add a new bookmark 
* open a new nautilus window

the bookmark icon for X will change back to the correct "folder" icon.
Comment 3 Andrew Sobala 2003-03-27 22:33:12 UTC
In 2.2, when recreating the directory the bookmark still can't be
found since it doesn't exist in trash:.
Comment 4 Sebastien Bacher 2003-11-22 15:04:42 UTC
43218 seems to be the same pb:

"To reproduce:
(1) Make a bookmark for your home directory
(2) Bring up the Edit Bookmarks window
(3) Note that the bookmark for your home directory has a folder icon as it
should (or a custom icon if you've got one of those)
(4) Select that bookmark in the list. For the location, append some
gibberish
such that it's not a real file name (e.g. "/home/sullivan/xxxxxxxx")
(5) Pull down the Bookmarks menu. Note that the icon has updated in
the menu to
be the missing-bookmark icon
(6) Note that in the Edit Bookmarks window the icon has not updated;
it is still
the old folder icon."
Comment 5 Sebastien Bacher 2003-11-22 15:05:49 UTC
*** Bug 43218 has been marked as a duplicate of this bug. ***
Comment 6 Kjartan Maraas 2005-01-04 18:31:17 UTC
Still seeing the original problem here with 2.8.x.
Comment 7 vishravars 2006-01-06 16:14:48 UTC
I think this bookmark problem can be handled as simple as possible. May be we shall not update anything in the book mark and let it show like "bookmark item not found or .... " in a dialog box. so that the user can remove that bookmark if e feels so.

i think this makes things quite straight forward to the user.
Comment 8 Christian Neumair 2006-01-06 20:39:45 UTC
http://mail.gnome.org/archives/nautilus-list/2006-January/msg00032.html has a patch.
Updating bug status.
Comment 9 Christian Neumair 2006-01-06 20:40:33 UTC
Created attachment 56883 [details] [review]
Proposed patch
Comment 10 Christian Neumair 2006-01-13 15:31:29 UTC
Attachment 56883 [details] was committed and fixes the issue described in comment 5.
Comment 11 Cosimo Cecchi 2010-05-06 16:55:37 UTC
*** Bug 446658 has been marked as a duplicate of this bug. ***
Comment 12 Cosimo Cecchi 2011-03-31 17:44:44 UTC
It seems this is still problematic.
Putting on the 3.0.x radar.
Comment 13 Vadim Rutkovsky 2012-03-07 14:44:13 UTC
Can't reproduce in Nautilus 3.3.91 - bookmark is displayed again after deleted folder is created
Comment 14 Cosimo Cecchi 2012-03-07 16:45:46 UTC
This doesn't really work as expected yet; when the directory is trashed/deleted the icon in the Bookmarks window won't change.
Comment 15 António Fernandes 2017-09-04 17:26:22 UTC
There is no Bookmarks menu or Bookmarks window anymore. Bookmarks are displayed in the sidebar which is now a Gtk+ widget. Their icons don't change when the bookmark is broken. As such, this bug as a whole is obsolete.

On the specific issue of dealing with broken bookmarks due to folder being sent to Trash, see bug 771466.