GNOME Bugzilla – Bug 447163
Implicit pointer conversion gdk_font_ref()
Last modified: 2007-06-14 06:39:13 UTC
Hi, Dann Frazier reported in Debian bug http://bugs.debian.org/381082: """ Our automated buildd log filter[1] detected a problem that will cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64. Looks like gdk_font_ref() is marked deprecated, so it shouldn't be used with GDK_DISABLE_DEPRECATED defined. [1]http://people.debian.org/~dannf/check-implicit-pointer-functions ----- Forwarded message from Debian/IA64 non-US Build Daemon <buildd@caballero.debian.org> ----- Subject: Log for successful build of gtk+2.0_2.8.18-5 (dist=unstable) From: Debian/IA64 non-US Build Daemon <buildd@caballero.debian.org> Date: Mon, 31 Jul 2006 17:24:23 +0100 To: undisclosed-recipients: ; X-PMX-Version: 5.1.2.240295, Antispam-Engine: 2.3.0.1, Antispam-Data: 2006.7.31.85932 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at ldl.fc.hp.com X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on ldl.lart X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.5 tests=AWL,BAYES_00,UNDISC_RECIPS, UPPERCASE_25_50 autolearn=no version=3.0.3 Debian-Buildd-Error: Yes Function `gdk_font_ref' implicitly converted to pointer at gdkgc-directfb.c:204 ----- End forwarded message ----- """ I'm going to attach his patch. Severity critical as this should cause crashes on amd64. Bye,
Created attachment 89885 [details] [review] Ignore GDK_DISABLE_DEPRECATED to get gdk_font_ref() properly defined
2007-06-13 Behdad Esfahbod <behdad@gnome.org> * gdk/directfb/gdkgc-directfb.c: #undef GDK_DISABLE_DEPRECATED to get prototype for gdk_font_ref(). (#447163, Dann Frazier, Loïc Minier)
This does not seem right to me ? I looked at the change why do I have to call a deprecated function ? I'm not clear what a replacement would be at the moment.
(In reply to comment #3) > This does not seem right to me ? > > I looked at the change why do I have to call a deprecated function ? > I'm not clear what a replacement would be at the moment. The gdk_font_* stuff is completely deprecated in favor of Pango, but since you are implementing a gdk backend you have to provide an implementation, which not surprisingly uses deprecated functions.
Got it.