GNOME Bugzilla – Bug 444499
build of fresh CVS is failing in ext/sdl
Last modified: 2007-06-06 16:40:51 UTC
Here is a patch fixing the build issue in CVS (gst-plugins-bad): ======= --- ext/sdl/Makefile.am.orig 2007-04-29 15:53:16.000000000 +0200 +++ ext/sdl/Makefile.am 2007-06-05 18:48:57.000000000 +0200 @@ -5,7 +5,7 @@ sdlvideosink.c \ sdlaudiosink.c -libgstsdl_la_CFLAGS = $(GST_PLUGINS_BASE_CFLAGS) $(SDL_CFLAGS) +libgstsdl_la_CFLAGS = $(GST_PLUGINS_BASE_CFLAGS) $(GST_CFLAGS) $(SDL_CFLAGS) libgstsdl_la_LIBADD = $(GST_PLUGINS_BASE_LIBS) \ -lgstvideo-$(GST_MAJORMINOR) \ -lgstaudio-$(GST_MAJORMINOR) \ ========
Thanks, committed: 2007-06-06 Tim-Philipp Müller <tim at centricular dot net> * ext/sdl/Makefile.am: * ext/sdl/sdlvideosink.c: (gst_sdlv_process_events): Add GST_CFLAGS, which apparently somehow fixes the build somewhere (#444499); initialise variable to avoid false compiler warning. Would be great if next time you could mention how the build breaks exactly, and on what kind of system, since it seems that none of us or any of the build bots noticed a problem here so far :)
This was under Ubuntu Gutsy (pre 7.10) using a local buildbot producing debs. Used to work, just -bad broken for the last few days. Too bad I haven't kept the logs (just reorganized my stuff). It failed at #include <gst/interfaces/x> because -I/usr/include/gstreamer-0.10 was missing from the cc line. No idea why this was different from other dirs. I confirm it's okay now. I have more failures caused by -Werror, should I open a case or just ignore those ?
Are those debs published somewhere public? :)
> Are those debs published somewhere public? :) you mean the deb sources or a repo directly usable ?
A repository (and the sources are probably the plain Ubuntu ones with minimal changes?)
> I have more failures caused by -Werror, should I open a case or just ignore > those ? No, please do file bugs for those, so we can fix them (assuming you're compiling CVS). Preferably one bug per module, with each bug containing the warnings for the entire module build. You can get that with something like gst-plugins-foo $ make clean gst-plugins-foo $ make ERROR_CFLAGS='-Wall' 2> warnings.log I think. Thanks!