GNOME Bugzilla – Bug 444119
Don't bump soname
Last modified: 2007-06-05 18:37:17 UTC
That change: http://svn.gnome.org/viewcvs/libwnck?view=revision&revision=1255 is the only one in the 2.19.3 release that requires a proper soname bump, and it doesn't seem that useful. With that change, you need to rebuild everything that depends on libwnck and libnotify, which is quite a lot of stuff. Is this really needed?
Bastien: WnckSelector also had an API change and new signals were added to WnckScreen. So it was not just one change.
I have this in Totem, to make me remember what needs upping when a new release comes in: # Before making a release, the PLPARSER_LT_VERSION string should be modified. # The string is of the form C:R:A. # - If interfaces have been changed or added, but binary compatibility has # been preserved, change to C+1:0:A+1 # - If binary compatibility has been broken (eg removed or changed interfaces) # change to C+1:0:0 # - If the interface is the same as the previous version, change to C:R+1:A You didn't need to up the soname until you committed that one change mentioned above, all the others kept binary compat for existing applications.
Bastien: isn't changing the size of WnckScreenClass breaking binary compatibility?
You're right. But you should have uncommented the padding as well, otherwise it's the same story next time you want to add some more signals...
Bastien: I wondered why I didn't do this yesterday night. I can uncomment the padding and release 2.19.3.1 today, so this won't cause another break. Is this okay for you?
It turns out I also wanted to commit another patch for this release, which breaks API: bug 136858. I'll ping Elijah/Havoc to see if they agree on it.
Might as well. And if the other objects don't have class padding, you might want to add some :)
2.19.3.1 is out now. ABI-incompatible changes should be possible to avoid in the near future, now. Slap me again if I did something wrong :-)