After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442823 - Pango structures fail to use GLib types
Pango structures fail to use GLib types
Status: RESOLVED NOTABUG
Product: pango
Classification: Platform
Component: general
1.14.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2007-06-01 07:52 UTC by Andrew Cowie
Modified: 2007-06-01 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Andrew Cowie 2007-06-01 07:52:33 UTC 
A glance at http://developer.gnome.org/doc/API/2.0/pango/pango-Glyph-Storage.html will show numerous functions taking double arguments.

Shouldn't these all be gdouble in a GNOME library?

[Since gdouble is presently typedef as double, fixing this shouldn't break anything, should it?]

AfC
Comment 1 Andrew Cowie 2007-06-01 08:20:55 UTC 
Seems to be a bit more general than I thought. PangoGlyphString has "char*" showing up. And "int" is in PangoRectangle.

AfC
Comment 2 Owen Taylor 2007-06-01 11:54:10 UTC 
gint, gdouble, etc, aren't there for portability or convenience, they are 
there for gconsistency with gint32, guint, and so forth.

I thought that was sort of cool when I first encountered GTK+, but by
the time I wrote pango A) my g key was wearing out B) I had seen too many
people on the mailing lists doing (gint)some_int.

I don't anybody in the GTK+ team really is that fond of these types, but
they are kept in GLib and GTK+ for consistency with the code already there.

If you find any occurences of useless gtypes in Pango, *that* is a bug.

(Pango does use gpointer, I'm not sure even that really makes sense; 
historically speaking gpointer is a clone of XPointer which dates back 
to before 'void *' existed...)