After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441786 - locks keyboard but not screen while applications are fullscreen
locks keyboard but not screen while applications are fullscreen
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Typing break
2.18.x
Other All
: Normal minor
: ---
Assigned To: Richard Hult
Control-Center Maintainers
: 501762 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-28 10:53 UTC by Pēteris Caune
Modified: 2008-07-17 17:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
make a break windwow modal (450 bytes, patch)
2008-06-29 12:20 UTC, Andrey Gusev
committed Details | Review
Better patch (655 bytes, patch)
2008-07-05 20:46 UTC, Andrey Gusev
none Details | Review

Description Pēteris Caune 2007-05-28 10:53:04 UTC
Please describe the problem:
If Firefox is fullscreen (F11) and Typing break time comes, screen does not lock. Keyboard stops working but mouse still moves and I can press on links etc. 
When I exit firefox fullscreen, screen locks (or, actually, locked screen image surfaces). 


Steps to reproduce:
1. Open Firefox in fullscreen
2. Wait for typing break



Actual results:
Screen does not lock, keyboard stops working

Expected results:
Lock screen, as usual

Does this happen every time?
yes

Other information:
I'm using Firefox 2.0.0.3, Ubuntu Feisty
Comment 1 Luis Villa 2007-12-13 22:16:58 UTC
Happens with full-screen openoffice as well.
Comment 2 Luis Villa 2007-12-13 22:26:37 UTC
*** Bug 501762 has been marked as a duplicate of this bug. ***
Comment 3 Luis Villa 2007-12-13 22:26:53 UTC
Dup is with terminal.
Comment 4 Andrey Gusev 2008-06-29 12:20:51 UTC
Created attachment 113606 [details] [review]
make a  break windwow modal

I offer this patch.
Comment 5 Jens Granseuer 2008-07-02 20:51:43 UTC
Thanks!

2008-07-02  Jens Granseuer  <jensgr@gmx.net>

        Patch by: Andrey Gusev <ronne@list.ru>

        * drw-break-window.c: (drw_break_window_init): make the typing break
        window modal so it properly locks the screen when apps like firefox
        are running in fullscreen mode (bug #441786)
Comment 6 Andrey Gusev 2008-07-05 20:46:44 UTC
Created attachment 114034 [details] [review]
Better patch

I didn't get mail by this bug, so I didn't now about committing previous patch. I use package with it and notes that screen blinks, before appearing a break window. I think, making window modal before showing it, is not correct. The new patch makes window modal after showing, in this case screen don't blink.
Comment 7 Jens Granseuer 2008-07-10 11:16:54 UTC
Can you explain what you mean by blinking screen? I did not see bad behaviour when I tested the patch.

(In reply to comment #6)
> I didn't get mail by this bug, so I didn't now about committing previous patch.

That is because you do not get added to the CC list when you just add an attachment. Did that now.
Comment 8 Andrey Gusev 2008-07-15 20:35:58 UTC
It looks like clear screen and show window after this. I have gnome composite option enabled and Intel video card. So, about most function is written, that it can be used before showing window, but it isn't written about "gtk_window_set_modal". It is not very noticeably.
Comment 9 Jens Granseuer 2008-07-17 17:52:03 UTC
Yes, you can make a window modal before showing it.

The behaviour you describe sounds more like a problem in the driver/X stack or the window manager. Programmatically, your first patch is "more correct", so if this isn't very noticable I'd prefer to leave it as is.