GNOME Bugzilla – Bug 441484
Need to adjust FF form field navigation to accommodate FF changes
Last modified: 2008-07-22 19:27:27 UTC
Some recent changes in Firefox lists have impacted our form field structural navigation. In particular, pressing Orca_Modifier+Tab from within a list would move to the next list item rather than the next form field. Pressing Orca_Modifier+Shift+Tab from immediately after a list would move focus to the list item but not give the parent list focus. Patch to follow.
Created attachment 88863 [details] [review] patch to hopefully solve the problem Mike please test. Thanks!
Two things I've noticed here. 1. When using move to next form control on the bugzilla bug search page each time I encounter a "multiselect list" I find the list on the first press of next form field and I find the first list item on the second. The other thing I'm noticing on this page is that checkbox labels are now being read twice.
Thanks! 1. What is going on there is not an Orca thing. Sometimes when you move focus to a multi-select list via the keyboard, nothing is selected but you're still on an item. Visually it has little dots surrounding it, but it's not highlighted. In these conditions, the first press of the Down Arrow causes it to be highlighted. Orca is announcing it the first time because we're on it and the second time because it became selected. What it is not announcing is the fact that initially the item was not highlighted. If you would like this behavior to be altered, please let me know exactly what Orca should say and in what conditions. In the meantime, since that's a different issue rather than the result of a change in FF and/or this patch, I'm going to check this patch in. 2. That seems to be something unique to that page. It happens when you Tab to them so it's not limited to structural navigation. It also doesn't happen with other checkboxes such as the Add me to CC list checkbox on this page. New issue, new bug. <smile> See bug 441610. Thanks again!
Regarding my previous comment: Mike I still need you to spec out what should happen in the "not selected" case, but I just noticed what you were seeing. I thought you meant arrowing, but it's the insert+tabbing. My bad!! I'll work on that now.
Created attachment 88891 [details] [review] handle the case Mike described in his last comment Mike, please see if this patch solves the problem you reported about the list item getting focus when you press Insert Tab after having already moved to the list. Thanks. (note: this patch does not obsolete the previous one as the previous one was checked in)
Works great! thanks
Thanks Mike! Patch committed. Changing status to pending so that we can test a few more days to be sure I didn't miss any other cases/changes.
Created attachment 88964 [details] [review] simpler solution Some days I marvel at the depths of my stupidity.... Here's a much better version that's consistent with what I had done to handle a similar case with combo boxes. Oh, and it only took one line of code. D'oh! Patch checked in, but please test "just in case."
Mike I'm putting your name back on this one since I did a new version.
This still seems to be working as expected. except for the javascript bug in firefox that allows me to take a walk around the block between key presses. Sigh that isn't an orca bug though.
Thanks for the test Mike. I know what you mean about the walk-around-the-block thing. I did ping the mozilla bug in question using advanced search as another example. Not sure how much good it will do. Feel free to join in the harassment, errrr, I mean advocacy. :-) https://bugzilla.mozilla.org/show_bug.cgi?id=379843 Closing as FIXED.