After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 440524 - EDS Under TotalView
EDS Under TotalView
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-05-22 18:37 UTC by Srinivasa Ragavan
Modified: 2012-10-10 03:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for memory leak in file backend. (832 bytes, patch)
2007-05-22 18:38 UTC, Srinivasa Ragavan 		none Details | Review
More fixes (6.19 KB, patch)
2007-05-24 16:57 UTC, Srinivasa Ragavan 		committed Details | Review
Groupwise leaks (3.36 KB, patch)
2007-05-24 16:59 UTC, Srinivasa Ragavan 		none Details | Review
Updated groupwise patch (3.82 KB, patch)
2007-05-25 06:01 UTC, Srinivasa Ragavan 		committed Details | Review

Description Srinivasa Ragavan 2007-05-22 18:37:27 UTC 
Im gonna have this as a tracker bug. I will attaching patches that would evolve out of my experiment of EDS under TotalView memory debugger.
Comment 1 Srinivasa Ragavan 2007-05-22 18:38:46 UTC 
Created attachment 88630 [details] [review]
Patch for memory leak in file backend.
Comment 2 Ross Burton 2007-05-22 18:51:29 UTC 
Patch looks good to me.

This exposes a semantic change that crept into eds-dbus: it takes ownerships of the vcards instead of making a copy.
Comment 3 Srinivasa Ragavan 2007-05-22 19:03:07 UTC 
Oh. I see. You can promote some of those changes into orbit impl if possible

Lets hope by the end of this bug, we see EDS using less memory. More patches on the way.
Comment 4 Ross Burton 2007-05-22 19:16:50 UTC 
If EDS is leaking the vcard for every contact because I was foolish enough to forget that the upstream EDS makes a copy, then yes this patch along will help a lot. :)
Comment 5 Srinivasa Ragavan 2007-05-24 16:57:56 UTC 
Created attachment 88745 [details] [review]
More fixes

This patch should fix more leaks for addressbook.
Comment 6 Srinivasa Ragavan 2007-05-24 16:59:07 UTC 
Created attachment 88746 [details] [review]
Groupwise leaks
Comment 7 Srinivasa Ragavan 2007-05-24 16:59:40 UTC 
Sankar: Can you review GW leak fixes.
Comment 8 Srinivasa Ragavan 2007-05-25 06:01:32 UTC 
Created attachment 88782 [details] [review]
Updated groupwise patch
Comment 9 Sankar P 2007-05-25 06:42:15 UTC 
(In reply to comment #8)
> Created an attachment (id=88782) [edit]
> Updated groupwise patch
> 

Looks Good. Commit to both Trunk and Branch.
Comment 10 Ross Burton 2007-05-25 09:38:56 UTC 
The patch in comment #5 looks good to me, commit away.
Comment 11 Srinivasa Ragavan 2007-05-27 17:04:24 UTC 
Ill commit them for head only for 2.11.3
Comment 12 Matthew Barnes 2008-03-11 01:01:34 UTC 
Bumping version to a stable release.
Comment 13 Akhil Laddha 2011-02-10 11:20:06 UTC 
srag, can this bug be closed now ?
Comment 14 Matthew Barnes 2012-10-10 03:00:16 UTC 
Looks like we're done here.  Closing as FIXED.