After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438926 - invalid comparison of pointer with string literal
invalid comparison of pointer with string literal
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.5
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-16 16:19 UTC by Stanislav Brabec
Modified: 2007-05-16 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-plugins-good-bad-comparison.patch (706 bytes, patch)
2007-05-16 16:31 UTC, Stanislav Brabec 		none Details | Review

Description Stanislav Brabec 2007-05-16 16:19:26 UTC 
I: Expression compares a char* pointer with a string literal.
   Usually a strcmp() was intended by the programmer
E: stringcompare gstdv1394src.c: 1077

In function 'gst_dv1394src_uri_set_uri':
gstdv1394src.c:1077: warning: comparison with string literal results in unspecified behaviour
Comment 1 Sebastian Dröge (slomo) 2007-05-16 16:31:06 UTC 
Thanks for reporting... this is fixed now in CVS

2007-05-16  Sebastian Dröge  <slomo@circular-chaos.org>

	* ext/raw1394/gstdv1394src.c: (gst_dv1394src_uri_set_uri):
	Replace direct comparison of a string with the string literal "" with
	a comparison of the first character with '\0'. Fixes #438926.
Comment 2 Stanislav Brabec 2007-05-16 16:31:40 UTC 
Created attachment 88298 [details] [review]
gst-plugins-good-bad-comparison.patch

Proposed fix.