After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438461 - mail preferences buttons doesn't have a consistent look
mail preferences buttons doesn't have a consistent look
Status: VERIFIED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other All
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-05-14 22:33 UTC by Gilles Dartiguelongue
Modified: 2013-09-13 00:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
mail-config.glade.patch (2.97 KB, patch)
2007-05-14 22:34 UTC, Gilles Dartiguelongue
committed Details | Review
screenshot-prefs2.jpg (57.99 KB, image/jpeg)
2007-05-15 08:35 UTC, Gilles Dartiguelongue
  Details
screenshot in german (8.58 KB, image/png)
2007-05-15 20:35 UTC, André Klapper
  Details
screenshot+patch in german (9.28 KB, image/png)
2007-05-16 06:32 UTC, Gilles Dartiguelongue
  Details

Description Gilles Dartiguelongue 2007-05-14 22:33:26 UTC
in the edit->preferences menu, the mail preferences buttons (new/edit/delete/enable/default) are not consistent. This is clearly seen in locales like french where the last 2 buttons are smaller than other buttons so the whole buttons gets smaller.

I notice that the glade file had an extra vbox that doesn't seem to be used (at least I couldn't find where it was used). So I simply moved the button inside the vbuttonbox with the others.

Patch to follow.

Other information:
Comment 1 Gilles Dartiguelongue 2007-05-14 22:34:58 UTC
Created attachment 88186 [details] [review]
mail-config.glade.patch

this should fix (works for french) the issue.
Comment 2 Srinivasa Ragavan 2007-05-15 08:18:04 UTC
Gillies, do you have a screenshot of the problem?
Comment 3 Gilles Dartiguelongue 2007-05-15 08:35:13 UTC
Created attachment 88192 [details]
screenshot-prefs2.jpg

no i after the l please :)

screenshot attached.
Comment 4 André Klapper 2007-05-15 20:35:35 UTC
Created attachment 88246 [details]
screenshot in german

even worse in german, because the word "Deaktivieren" is too long for the button, so the last letter is not rendered correctly.
Comment 5 Srinivasa Ragavan 2007-05-16 04:32:49 UTC
Gilles the patch seems OK. But it needs to be tested more languages
Comment 6 Gilles Dartiguelongue 2007-05-16 06:32:45 UTC
Created attachment 88260 [details]
screenshot+patch in german

I've tested with japanese and german and it looked well.

On the attached screenshot, the add and delete button are in english because I didn't compile gtk with german locale. I can recompile gtk if necessary.
Comment 7 Srinivasa Ragavan 2007-05-19 21:17:31 UTC
Gilles, thanks a lot dude. I'll commit it .
Comment 8 Srinivasa Ragavan 2007-06-03 13:27:20 UTC
Fixed.
Comment 9 Gilles Dartiguelongue 2007-06-09 19:54:05 UTC
marking as verified, thanks for including