GNOME Bugzilla – Bug 438032
Use Tango icons
Last modified: 2007-05-14 13:45:22 UTC
There are Tango gnome games icons (GPL) available here: http://gnome-look.org/content/show.php/gnome-games+icons?content=52906 We should be using them!
OK, I've added all these icons into icons/ It's not connected to the build system yet though
Created attachment 88106 [details] [review] Patch to use new icons Here's an initial patch to use these new icons. The Python games (sudoku and glchess) need more work These files are removed: D glchess/data/glchess.svg D aisleriot/gnome-aisleriot.png D aisleriot/gnome-freecell.png D gnomine/22x22 D gnomine/22x22/gnome-gnomine.png D gnomine/32x32 D gnomine/32x32/gnome-gnomine.png D gnomine/16x16 D gnomine/16x16/gnome-gnomine.png D gnomine/48x48 D gnomine/48x48/gnome-gnomine.png D gtali/pix/22x22 D gtali/pix/22x22/gnome-tali.png D gtali/pix/32x32 D gtali/pix/32x32/gnome-tali.png D gtali/pix/16x16 D gtali/pix/16x16/gnome-tali.png D gtali/pix/48x48 D gtali/pix/48x48/gnome-tali.png D gtali/pix/scalable D gtali/pix/scalable/gnome-tali.svg D blackjack/pixmaps/gnome-blackjack.xcf D blackjack/pixmaps/gnome-blackjack.png D gnometris/pix/gnome-gnometris.png D gnotravex/gnome-tetravex.png D gnotski/gnome-klotski.png D glines/gnome-five-or-more.png D gnibbles/scalable D gnibbles/scalable/gnome-nibbles.svg D gnibbles/16x16 D gnibbles/16x16/gnome-nibbles.png D gnibbles/22x22 D gnibbles/22x22/gnome-nibbles.png D gnibbles/48x48 D gnibbles/48x48/gnome-nibbles.png D gnibbles/32x32 D gnibbles/32x32/gnome-nibbles.png D same-gnome/gnome-same-gnome.png D mahjongg/gnome-mahjongg.png D iagno/22x22 D iagno/22x22/gnome-iagno.png D iagno/32x32 D iagno/32x32/gnome-iagno.png D iagno/16x16 D iagno/16x16/gnome-iagno.png D iagno/48x48 D iagno/48x48/gnome-iagno.png D iagno/scalable D iagno/scalable/gnome-iagno.svg D gnobots2/gnome-robots.png D gnobots2/gnome-robots.svg D gnect/data/gnome-four-in-a-row.png D gnome-sudoku/images/sudoku.png
Yes, let's use these tango icons in gnome-games. (However, the last time these icons were suggested, there was some controversy over using some of them.)
Before applying the above patch, make sure that it doesn't break the changes introduced in Bug #436258. "Run gtk-update-icon-cache in uninstall-hook" which was a gnome-goal (See: http://live.gnome.org/GnomeGoals/AppIcon). By the way gnome-games 2.19.2 is due Monday May 14th.
Did you forget to add icons/Makefile.am to the diff ?
No, it's already in SVN.
I didn't connect the new icons to the build system because I think we should release 2.19.2 first. An 11th hour change like this would be too dangerous :) So I propose the patch is committed (and the Python games updated) after 2.19.2 is released to give us some time to test. I'm trying to follow the logic of the controversy but I'm lost! This change seems like a no-brainer to me :)
(The controversy Andreas is talking about is in bug 354507) When this bug is completed we should be able to close 354507 and 359499
Closing this as a duplicate of bug 354507... see you there! *** This bug has been marked as a duplicate of 354507 ***