GNOME Bugzilla – Bug 436914
Reply to inline GPG quotes raw GPG message
Last modified: 2011-03-01 11:23:25 UTC
Please describe the problem: Evolution an GPG seems to be working correctly on my desktop. I can send and receive crypted or signed mail (GPG functionnality). However, if somebody answers to my initial crypted mail with a crypted answer (verified since Thunderbird only), Evolution doesn't try to decrypt the mail at all. The crypted content is displayed as is. I must precise that this happens only with answers: if the same person sends me a crypted email with Thunderbird/Enigmail/GPG, Evolution decrypts it properly. For the moment, it is possible to copy the mail and paste it in a text file to get it decrypted in the command line, but it's not the way I except Evolution to manage crypted mails in the future. Steps to reproduce: 1. Send a GPG crypted mail to anyone using Thunderbird/Enigmail/GPG. 2. Ask him to answer your mail and to crypt and sign the answer. 3. Receive the mail: although you do have the correct GPG key, and although any crypted mail is correctly read, crypted answers are not. Actual results: Evolution displays the crypted mail as is (unreadable). Expected results: Evolution should decrypt an crypted answer, as it does for any initial crypted mail. Does this happen every time? Yes: it's systematic. Other information: Screenshotof the problem here: http://forum.heible.free.fr/EvolutionGPGbug/Capture.png
this is probably because your correspondant is using inline pgp (altought I thought it was supported by now). Could you look at the source of the mail (ctrl+u) and paste each line starting by : "Content-Type:" here ?
OK, here it is: X-Enigmail-Version: 0.94.0.0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-ProXaD-SC: Score=30
the problem is probably that they are in html format rather than plain text.
(In reply to comment #3) > the problem is probably that they are in html format rather than plain text. > Yes, it seems: <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> -----BEGIN PGP MESSAGE----- <br> Charset: ISO-8859-1 <br> Version: GnuPG v1.2.1 (MingW32) <br> Comment: Using GnuPG with Mozilla - <a class="moz-txt-link-freetext" href="http://enigmail.mozdev.org">http://enigmail.mozdev.org</a> <br> <br> hQIOA4DHW+BU3lTiEAf/T0WoY9WUM79FoIOzopQr5ItqSdb+6KJZKXRy9F5XRrH9 <br> 9qlvancwLxi7nkC5SbnKqPIraRHuJFONKKi5S+18bJOY55DieNHcAaOctfvT6QPm <br> A3mqYE3mZPgGl1Y8nVxoSBVtAx7QvxKJS9IcMtBBKGgg75G4YWleiq8er4DrR59x <br> QrLCXnE6uYLKXOMsChSryQn8HEtIgtGUnzfWGRvkH3CFoKW9NXVb/mJEyMQrQ9p4 <br> BAt/zcQEnPgdjSTZdu3SeCflS4uY1EkS7HtH4l/MvICfv6i1dQEYb642Kk5Csjao <br> Is it a normal behaviour of Evolution, or should it decrypt the message?
I'm not an expert, but it doesn't look like a valid PGP message to me. There is an open bug about evolution not encrypting html mail that explain how it is a braindead concept anyway but I can't find it.
(In reply to comment #5) > I'm not an expert, but it doesn't look like a valid PGP message to me. > There is an open bug about evolution not encrypting html mail that explain how > it is a braindead concept anyway but I can't find it. > I do regularly use Evolution/PGP encryption of html mail, and it's functional. That's right, the Evolution/PGP messages I do send are quite different: boundary="=-40rc2MPYbZT0SPkyR5fE" [...] --=-40rc2MPYbZT0SPkyR5fE Content-Type: application/pgp-encrypted Content-Transfer-Encoding: 7bit Version: 1 --=-40rc2MPYbZT0SPkyR5fE Content-Type: application/octet-stream; name=encrypted.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= Content-Transfer-Encoding: 7bit -----BEGIN PGP MESSAGE----- Version: GnuPG v1.4.6 (GNU/Linux) hQIOA7eoPwAaUykQEAf/V997FFS8yyXz/828DXlryuJjck3nc6VuBSwptiVBBRAr wmDWVrEh63jS1fHwq7DEUToxYyTQvc1jxIa/rCR0XUFov93BGPLZ/oLbJrZtR22y QT82oKgPKNxj0Kocz3OfSexjS0qDS4+e0hS9UiZuBK8+ggQEcaLebv+MILyPEVzC But I think Evolution should decrypt these messages anyway, as other very popular mailers format messages that way. Don't you?
seems like evolution encrypts the whole html. I believe that mixing crypted message with html (in the sense of putting html inside and encrypted messsage like the example of comment #4) is totaly wrong. I they don't want some characters of the message to be misinterpreted they should use <[[CDATA[ ]]> style encapsulation. But I'm not a evo dev so waiting for what they have to say about it :)
I think you're referring to bug #217541 the main problem with the way Enigmail did the inline-pgp in your example message is that it did the inline-pgp operation and THEN wrote out the html, adding tags in the inline-pgp block in essence, what Thunderbird must do is "screen-scrape" the encrypted block out of the body after rendering it as html. unfortunately Evolution doesn't work this way, it has to know that the inline-pgp encrypted block is there before it even tries to render it because it has to modify the data it sends to the html renderer (adding special tags, etc). the way Thunderbird does this isn't quite as bad as Outlook (example in the linked bug), so it /might/ be possible to work around the Thunderbird html mess, but trying to do it generically would mean a lot more processing (we'd have to write an html parser in the mailer code or camel code... wherever the inline-pgp sniffer is, I forget, to "screen-scrape" and then check for inline-pgp blocks which would be totally nasty to code) again, working around this particular case (Thunderbird inline-pgp /encrypted/ blocks inside text/html parts) is probably doable, as it appears it just adds " <br>" to the end of each line, so a special-case hack could probably be written. but to solve this the Right Way(tm) = painful if not impossible
oh, also, evolution does not even currently check text/html parts for inline-pgp blocks of either kind.
*** Bug 594642 has been marked as a duplicate of this bug. ***
*** Bug 633629 has been marked as a duplicate of this bug. ***
The above bugs are describing the same issue with text/plain parts sent by Thunderbird, and if I got it right they fixed the issue with text/html in Thunderbird itself, thus I'm using this bug to address "Reply to inline GPG quotes raw GPG message" issue.
Created attachment 176333 [details] [review] evo patch for evolution; I moved em-inline-filter from evo/mail to evo/em-format and I use it here, with a little bit of improvements in the inline filter itself too. It coves this particular use case. If discovered, we can extend it for other usages too.
Created commit a8bde44 in evo master (2.91.4+)
Could this patch be backported to 2.32.x or would this be too much work? At least I can still reproduce this issues using Evolution 2.32.2 in Debian Sid/unstable.
I'm sorry, there is not planned any update on 2.32 branch of evolution. Backporting it might be doable, though, but I wouldn't lose time on it, as 2.30.x is even older than 2.32.2.
(In reply to comment #16) > I'm sorry, there is not planned any update on 2.32 branch of evolution. Understood. > Backporting it might be doable, though, but I wouldn't lose time on it, as > 2.30.x is even older than 2.32.2. For me it would just be needed to be backported to 2.32x and not 2.30.x.