After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436258 - [Patch] Run gtk-update-icon-cache in uninstall-hook
[Patch] Run gtk-update-icon-cache in uninstall-hook
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.19.x
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks: 362604
 
 
Reported: 2007-05-06 03:15 UTC by David Farning
Modified: 2007-05-09 20:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch to run gtk-update-icon-cache in uninstall-hook (1.05 KB, patch)
2007-05-06 03:16 UTC, David Farning 		rejected Details | Review
Update patch (1.05 KB, patch)
2007-05-09 19:58 UTC, Brian Pepple 		none Details | Review

Description David Farning 2007-05-06 03:15:07 UTC 
Please describe the problem:
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook. Refer to #362604.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 David Farning 2007-05-06 03:16:58 UTC 
Created attachment 87642 [details] [review]
patch to run gtk-update-icon-cache in uninstall-hook
Comment 2 Brian Pepple 2007-05-07 18:03:50 UTC 
Comment on attachment 87642 [details] [review]
patch to run gtk-update-icon-cache in uninstall-hook

David, the patch contains an error.  You have two definitions for the 'install-data-hook'. The second one before the test should be 'update-icon-cache'.
Comment 3 Andreas Røsdal 2007-05-09 19:47:18 UTC 
Brian, I get the following error when running 'make distcheck' with your patch applied. Could you please submit an updated patch:


make[4]: Nothing to be done for `install-exec-am'.
test -z "/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_inst/share/applications" || mkdir -p -- "/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_inst/share/applications"
 /usr/bin/install -c -m 644 'gnome-sudoku.desktop' '/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_inst/share/applications/gnome-sudoku.desktop'
make[4]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build/gnome-sudoku'
make[3]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build/gnome-sudoku'
make[2]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build/gnome-sudoku'
make[2]: Entering directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[3]: Entering directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[3]: Nothing to be done for `install-exec-am'.
make  install-data-hook
make[4]: Entering directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[4]: *** No rule to make target `update-icon-cache', needed by `install-data-hook'.  Stop.
make[4]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[3]: *** [install-data-am] Error 2
make[3]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/andreas/gnome/gnome-games/gnome-games-2.19.1/_build'
make: *** [distcheck] Error 2
Comment 4 Andreas Røsdal 2007-05-09 19:51:32 UTC 
And make sure that your patch passes 'make distcheck'   :-)
Comment 5 Brian Pepple 2007-05-09 19:58:57 UTC 
Created attachment 87912 [details] [review]
Update patch

Andrea, try this one.
Comment 6 Andreas Røsdal 2007-05-09 20:26:43 UTC 
Thanks! Patch applied to SVN:

http://svn.gnome.org/viewcvs/gnome-games?view=revision&revision=6229