After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436242 - depend on GTK+ 2.10.13
depend on GTK+ 2.10.13
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal major
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on: 347883
Blocks:
 
 
Reported: 2007-05-06 00:38 UTC by Sven Neumann
Modified: 2007-07-24 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sven Neumann 2007-05-06 00:38:41 UTC
In the GIMP save dialog, you don't get the overwrite confirmation dialog if you enter just a filename without extension. GIMP adds the extension after the response callback and runs gtk_dialog_response() again to allow GtkFileChooser to do the check and to show the confirmation dialog in case the file already exists.
Unfortunately this doesn't work with recent versions of GtkFileChooser (see bug #347883). Since this is unlikely to be fixed in GTK+, we need to find a workaround.
Comment 1 Michael Natterer 2007-06-02 11:19:42 UTC
This has been fixed in GTK+. The final GIMP 2.4 must thus depend
on GTK+ 2.10.13 which will contain the fix.
Comment 2 Sven Neumann 2007-07-03 13:08:19 UTC
Debian testing now has GTK+ 2.10.13. I suggest that we bump up the requirement for the next development release.
Comment 3 Akkana Peck 2007-07-16 21:55:02 UTC
If it's a gtk bug, then please, can gimp wait on requiring the newer gtk? Tell people about the bug and encourage them to upgrade gtk if they can, but requiring a gtk that most people will have to build from source makes it a lot harder for anyone to build and test 2.3.
It's really a gtk bug, not a gimp bug, right?
Comment 4 Sven Neumann 2007-07-17 07:01:03 UTC
It is a GTK+  bug and for GIMP 2.4 we will require a version of GTK+ that has this bug fixed. Perhaps we don't need to do this for the 2.3.19 release but we should bump up the requirement directly after so that 2.4.0 is released with this bug addressed.
Comment 5 Raphaël Quinet 2007-07-17 07:58:05 UTC
I agree about bumping up the requirement directly after the 2.3.19 release.

FWIW, many users of current Linux distributions will probably have GTK+ 2.10.13 or newer: Debian testing and sid have 2.10.13, the current versions of Ubuntu,
Fedora (rawhide), OpenSUSE and Mandriva all have 2.11.15 (although their respective stable releases had 2.10.11 except for OpenSUSE that had the older 2.10.6), the stable Slackware 12 was recently released with 2.10.13, and Gentoo unstable has 2.10.13 as well.  Even FreeBSD stable has 2.10.13.  So those who are really interested in using the bleeding edge GIMP packages will probably be able to also get the latest GTK+ packages from their distribution.
Comment 6 Michael Schumacher 2007-07-17 11:23:29 UTC
The advantage of bumping the version now is that people who intend to run 2.4 on their systems will have more time to prepare the environment, if necessary.

Unlike the check for e.g. PyGTK, that fact that configure is checking for GTK+ >= 2.10.13 is announced. IMO it is frustrating to discover that you can't build a final release (assuming that a 2.3.19 might be the latest 2.3) if you could build all previous development releases.
Comment 7 Akkana Peck 2007-07-17 17:15:38 UTC
Good point about making sure that distros upgrade their GTK, so at least their next releases will have .13 and so they won't get a surprise later in their release cycles.

It's not necessarily true that people interested in testing gimp are also interested in testing the beta releases of their distro. Many are probably running the current (not upcoming) distro releases, and won't be able to get 2.10.13 easily. But folks in that position will be able to edit configure.in locally and build with older gtks ... right?
Comment 8 Sven Neumann 2007-07-17 18:35:14 UTC
First of all, this discussion doesn't belong to the bug-tracker. Second, we have had it before and decided that it's fine to depend on a package that is in debian testing for a while. Third, no, people won't be able to get away with editing configure.in since we are also checking the version at runtime. Fourth, building a released stable version of GTK+ is much simpler than building a development version of GIMP so it is definitely not asked too much.
Comment 9 Sven Neumann 2007-07-24 13:49:08 UTC
Bumping up the requirement now as we want to push out 2.4.0 real soon now and the more time people get to get used to the fact that 2.4 will require gtk+ 2.10.13, the better.

2007-07-24  Sven Neumann  <sven@gimp.org>

	* INSTALL
	* configure.in
	* app/gui/gui.c: depend on gtk+ >= 2.10.13. Fixes bug #436242.