After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435523 - totem gstreamer licence exemption + plugin engine
totem gstreamer licence exemption + plugin engine
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-05-03 15:21 UTC by Bastien Nocera
Modified: 2009-10-30 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2007-05-03 15:21:20 UTC
+++ This bug was initially created as a clone of Bug #433115 +++

Totem includes the Gedit/Ephy/Rhythmbox plugin system which is GPL without the gstreamer excemption.

Committers from gedit:
jessevdk
kmaraas (trivial)
paolo
pborelli
sfre

Committers from Epiphany:
adamh
chpe
crispin
diegoe (trivial, patch from Chris Wilson)
jframeau (trivial, only a comment)
marco

Committers from Rhythmbox:
hadess (agreed!)
jmatthew
jrl
mccann
rps (trivial one-liner)
sfre (already in the gedit list)
teuf

Let me know if I forgot anyone.
Comment 1 Paolo Borelli 2007-05-03 16:27:24 UTC
relicensing is fine by me.

kikidonk also did work on gedit plugin system (mostly the python plugins)
Comment 2 Marco Pesenti Gritti 2007-05-03 16:58:09 UTC
Fine by me
Comment 3 Bastien Nocera 2007-05-03 17:10:26 UTC
(In reply to comment #1)
> relicensing is fine by me.
> 
> kikidonk also did work on gedit plugin system (mostly the python plugins)

Adding Raphaël to the CC: then.

Comment 4 Christophe Fergeau 2007-05-03 17:53:02 UTC
I don't think I've contributed a significant amount of code to the plugin framework, I guess I was added to the list because of my trivial patch to sort the plugin list in the plugin selection dialog. Whatsoever, I'm ok with the relicensing.
Comment 5 Paolo Maggi 2007-05-04 07:58:03 UTC
I'm ok with the relicensing.
Comment 6 Jonathan Matthew 2007-05-04 08:27:02 UTC
Fine by me
Comment 7 Bastien Nocera 2007-05-10 15:38:30 UTC
Update on the 

Committers from gedit:
jessevdk
kmaraas (trivial)
paolo (agreed)
pborelli (agreed)
sfre

Committers from Epiphany:
adamh
chpe
crispin (agreed)
diegoe (trivial, patch from Chris Wilson)
jframeau (trivial, only a comment)
marco (agreed)

Committers from Rhythmbox:
hadess (agreed!)
jmatthew (agreed)
jrl
mccann (agreed)
rps (trivial one-liner)
sfre (already in the gedit list)
teuf (agreed)
Comment 8 James "Doc" Livingston 2007-05-10 22:28:41 UTC
Fine by me.

Of the people that haven't replied yet, I'd received permission from adamh and sfre for the relicencing in Rhythmbox.
Comment 9 Bastien Nocera 2007-05-10 22:37:56 UTC
(In reply to comment #8)
> Fine by me.
> 
> Of the people that haven't replied yet, I'd received permission from adamh and
> sfre for the relicencing in Rhythmbox.

Only Christian and Jesse left then. Does anyone know how to contact Jesse? I'm sure Christian will reply in due time :)
Comment 10 Paolo Borelli 2007-05-10 22:55:28 UTC
jesse hangs out in #gedit usually, but probably bugmail gets lost in the noise.
Comment 11 Steve Frécinaux 2007-05-10 23:55:58 UTC
ok for me
Comment 12 Raphael Slinckx 2007-05-11 09:35:20 UTC
Ok for me too !
Comment 13 jessevdk@gmail.com 2007-05-12 09:44:32 UTC
Fine by me!
Comment 14 Christian Persch 2007-05-13 12:23:28 UTC
I hereby give you permission to use the parts of the plugin system's code taken from epiphany (directly, or via rhythmbox, or gedit) that I own the copyright on, as that code exists in totem svn trunk as of yesterday, 12.5.2007, under the GPL version 2 or later, with the totem gstreamer licence exemption added.
Comment 15 Bastien Nocera 2007-05-13 13:02:34 UTC
Thanks a lot guys! It's all sorted now (Crispin and Jon replied by mail, instead of on this bug).

2007-05-13  Bastien Nocera  <hadess@hadess.net>

        * license_change:
        * src/plugins/totem-module.c:
        * src/plugins/totem-module.h:
        * src/plugins/totem-plugin-manager.c:
        * src/plugins/totem-plugin-manager.h:
        * src/plugins/totem-plugin.c:
        * src/plugins/totem-plugin.h:
        * src/plugins/totem-plugins-engine.c:
        * src/plugins/totem-plugins-engine.h:
        Add exception clauses to the above mentioned filed, thanks to the
        copyright holders for agreeing to the relicensing
        (Closes: #435523)

        * src/plugins/screensaver/totem-screensaver.c:
        * src/plugins/media-player-keys/totem-media-player-keys.c:
        * src/plugins/sidebar-test/totem-sidebar-test.c:
        * src/plugins/galago/totem-galago.c:
        * src/plugins/ontop/totem-ontop.c:
        Remove wrong mention of a relicensing date, all those files
        date from after the relicensing, just mention the
        license_change file instead

        * src/plparse/totem-disc.c: Update copyright, fix
        excemption/exception again
Comment 16 Adam Hooper 2009-10-30 13:03:32 UTC
Fine by me.