After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435355 - [Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook
[Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
1.2.x
Other All
: Normal normal
: ---
Assigned To: David Farning
David Bolter
Depends on:
Blocks:
 
 
Reported: 2007-05-03 00:28 UTC by David Farning
Modified: 2007-05-07 21:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
patch to run gtk-update-icon-cache in install-hook and uninstall-hook (2.02 KB, patch)
2007-05-03 00:43 UTC, David Farning
committed Details | Review
revert string freeze break (941 bytes, patch)
2007-05-07 21:20 UTC, Christian Kirbach
committed Details | Review

Description David Farning 2007-05-03 00:28:05 UTC
Please describe the problem:
Please describe the problem:
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook. Refer to #362604.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 David Farning 2007-05-03 00:43:40 UTC
Created attachment 87421 [details] [review]
patch to run gtk-update-icon-cache in install-hook and uninstall-hook
Comment 2 David Bolter 2007-05-03 00:55:18 UTC
Thanks David. Can you commit?
Comment 3 David Farning 2007-05-03 01:06:33 UTC
(In reply to comment #2)
> Thanks David. Can you commit?
> 
David

NO, not yet.  I just started working on gnome.  I though that I would start working on a few of these cleanup issues to get a feel for the project.

Thanks
David
Comment 4 Christian Kirbach 2007-05-05 11:03:48 UTC
your ChangeLog entry was somewhat bogus

+2007-05-02  David Farning  <dfarning@gmail.com>
+
+�-------* Makefile.am (update-icon-cache): fix
+�-------gtk-update-icon-cache for install and
+�-------uninstall-hook.
+�-------* gok/main.c: set default icon from cache


I revised it.

Commited to trunk on behalf of David. Thanks for the patch.
Comment 5 David Bolter 2007-05-05 12:02:44 UTC
Thanks very much David, and thanks for committing Christian. (Closing as fixed, please reopen if necessary)
Comment 6 David Bolter 2007-05-05 12:06:53 UTC
Reassigning bug to the patch contributor for bookkeeping.
Comment 7 Christian Kirbach 2007-05-07 21:18:24 UTC
2007-05-07  Christian Kirbach  <Christian.Kirbach@googlemail.com>

       * gok/main.c:
       Replacing "Gok" by "GOK" string to revert string freeze break
       committed by previous change. Hint from Claude Paroz.
Comment 8 Christian Kirbach 2007-05-07 21:20:05 UTC
Created attachment 87750 [details] [review]
revert string freeze break