GNOME Bugzilla – Bug 435223
Where-am-I doesn't correctly identify multiple selected objects in Nautilus
Last modified: 2007-05-10 05:56:10 UTC
This is from Hermann in comment #6 in bug #430278: "1) When i select files/folders in Nautilus the selection is not spoken. Orca speaks the last item I'm on. I have to check the status bar in order to see what I've selected."
Mike, yesterday you mentioned that you had updated the Orca spec to describe what should be done for multiple object selection. I've just looked in section 3.15. "Where Am I?" Command in .../orca/trunk/docs/doc-set/orca.html and I see no references to this. What file did you update and what should be done to handle this? i.e what should be spoken/brailled when multiple objects are selected in a Nautilus folder? Thanks.
Mike, according to your last comment in bug #435226, you say: "I forgot to check this in. It is now done and the files are checked into subversion." Could you tell me exactly what files you have changed and checked into subversion pertaining to this problem? I've looked in the Orca spec (.../orca/docs/doc-set/orca.html) in section 13.15 and I see nothing about what should be spoken or brailled when there are multiple icons selected. Note that it's also possible to select multiple Nautilus icons on the desktop as well as in a specific icon folder view.
I've also just added a new part to the "where am I" information for icon panels.
Thanks Mike. I'm still a little confused here though. I've just had a look at what you wrote, which is: Icon Panels present the following information (an example is "Icon Panel, Mike Pedersen, item 8 of 10, tree level 2"): 1. label, if any 2. role 3. relative position 4. all other selected icons followed by "selected I've just tried where-am-I from within a Nautilus folder, where view-by-icon is set and several icons are selected. Currently Orca just output the following: SPEECH OUTPUT: 'gnome' SPEECH OUTPUT: 'icon' where 'gnome' is the label of the first selected icon (i.e. the icon with focus). The component ancestry at this point was: +-name='nautilus' role='application' state='' relations='' +-name='richb - File Browser' role='frame' state='ACTIVE ENABLED RESIZABLE SENSITIVE SHOWING VISIBLE' relations='' +-name=None role='panel' state='ENABLED SENSITIVE SHOWING VISIBLE' relations='' +-name=None role='split pane' state='ENABLED FOCUSABLE HORIZONTAL SENSITIVE SHOWING VISIBLE' relations='' +-name=None role='filler' state='ENABLED SENSITIVE SHOWING VERTICAL VISIBLE' relations='' +-name=None role='filler' state='ENABLED SENSITIVE SHOWING VERTICAL VISIBLE' relations='' +-name='Content View' role='scroll pane' state='ENABLED FOCUSABLE SENSITIVE SHOWING VISIBLE' relations='' +-name='Icon View' role='layered pane' state='ENABLED FOCUSABLE FOCUSED SENSITIVE SHOWING VISIBLE' relations='' +-name='gnome' role='icon' state='FOCUSABLE SELECTABLE SELECTED SHOWING VISIBLE' relations='' There isn't really an icon panel here. So let's take my example further. Say I have the following four icons selected in the Nautilus folder icon view (which contains about twenty icons in total). The selected ones are labeled: gnome Mail speech app_gui_prefs.py What should be brailled/spoken by Orca for where-am-I in this case? Thanks.
> There isn't really an icon panel here. > So let's take my example further. Say I have the following four > icons selected in the Nautilus folder icon view (which contains > about twenty icons in total). The selected ones are labeled: > gnome > Mail > speech > app_gui_prefs.py > What should be brailled/spoken by Orca for where-am-I in this case? As far as braille goes you won't do anything here because selection will be handled by braille underlining when we implement that. For speech what you will do is first speak the label for the pane if it exists followed by gnome Mail speech app_gui_prefs.py followed by "selected"
> For speech what you will do is first speak the label for the pane if it exists > followed by > gnome > Mail > speech > app_gui_prefs.py > followed by "selected" Should there be a limit or some other way to speak the selection of a large number of items? For example, "selected from gnome to app_gui_prefs.py" or "selected 4 items" or something like that?
It's possible that the selections are not contiguous so trying to get clever for contiguous selections might be more trouble then it's worth. By looking at the containing object, we can determine howe many icons there are in total. We can also determine how many are selected, so something like "Icon panel" 20 items. 4 selected. gnome Mail speech app_gui_prefs.py selected" might be the way to go here.
We talked about this further in our team meeting today. The concensus now is to do the following: "Icon panel 20 items. 4 selected. gnome Mail speech app_gui_prefs.py" Note that there will always be at least one icon selected.
Created attachment 87852 [details] [review] Patch to fix this bug. Well, whadya know. You can have focus on an icon in a Nautilus view and it isn't selected. Control-Up/Down/Left/Right does that. It's also possible to have a load of other selected icons too. So the approach I've taken with the first cut at this patch is to first speak "Icon panel. n items", where n is the number of children in the parent object. I then speak the name of the item which currently has focus. If there is only one item that is selected in the folder and this is the one that has focus, this is just followed by "selected". If there is more than one selected (or zero selected), then instead it speaks "n selected", where n is the number of selected items. Then for each of those selected items, it speaks their name. I think it's pretty good. Let me know what you think. Patch NOT committed yet, unless we all agree on what should be done. Thanks.
I like this a lot, Rich! If I were to make any changes, it would just be to move the currently selected item to the end. When I tested it, I had selected 4 folders within my ~/orca directory: * autom4te.cache * bugs * docs * m4 Through the magic of Control+Arrows, bugs was the folder with focus. Orca spoke: * Icon panel, 56 items * bugs * 4 selected * autom4te.cache, bugs, docs, m4 This might be the ADHD talking, but at this point, my brain is thinking "m4" and not "bugs." If I were to then to continue to select with Shift+Right Arrow, I'd be expecting to add po to the selection thus bringing the total selected items to 5; in reality, I'd be unselecting all but bugs and then re-adding docs to the selection. Therefore, what about changing the order to: * Icon panel, 56 items * 4 selected * autom4te.cache, bugs, docs, m4 * bugs ? Just a thought.... Also, what about adding this support when the icons are being viewed as a list/tree? I think that would be handy for a lot of users.
As a quick follow-up: If I were on m4 instead of bugs, my suggestion would lead to: * Icon panel, 56 items * 4 selected * autom4te.cache, bugs, docs, m4 * m4 So if we do as I suggest, perhaps we should only speak the item with focus if it's different from the last item spoken so that we don't repeat ourselves.
Okay, thanks Joanie. My own personal preference is that I'd want to know the focused item as soon as possible. I wouldn't want to have to wait for umpteen selected icons to be spoken first. Also note that for most people using the Nautilus folder view, I strongly suspect that they will just Tab or arrow around and there will only ever be one item selected. But before I do any tweaks, I'd like Mike to do his impression of a bell and chime in.
> My own personal preference is that I'd > want to know the focused item as soon > as possible. I wouldn't want to have to > wait for umpteen selected icons to be > spoken first. I tend to agree with this and would put the focused item as early as possible in the utterance. For example: * m4 icon * Icon panel, 56 items * bugs * 4 selected * autom4te.cache, bugs, docs, m4 But, it also does depend upon which flavor of Where Am I the user invoked. I think we need Mike's input on this.
I think the selection functionality is really more intended for the doublepress of the where am I key. Using a previous example assuming that m4 is the item of focus here is what I think we should do. * Icon panel, m4 icon 4 of 56 items selected * autom4te.cache, bugs, docs, m4 Perhaps the single press should be: * Icon panel, m4 icon 4 of 56 items selected thoughts?
Sounds good to me. I'll adjust to this now. Thanks.
Created attachment 87914 [details] [review] Revised patch based on feedback. Patch committed. Sounds good. You know, I always think we've made the right design choice when the code gets smaller and cleaner. Putting the bug into a "[pending]" state.
Hey Rich, this seems to be working well now. I've just tested it both on the desktop and in nautilus.
Cool. Thanks Mike. Closing at fixed.