GNOME Bugzilla – Bug 434274
Frosty doesn't work when used on a small text layer
Last modified: 2008-10-30 19:57:05 UTC
From Debian bug report http://bugs.debian.org/405200. Note that the original bug report complained about GIMP freezing, but that shouldn't happen in GIMP 2.3.16. This report is merely about the script error, which is still present. I am trying to Frosty (scriptfu>alpha to logo>frosty) a line of text on a text layer with default Frosty settings (100px, white bg). It crashes with the following error in an error popup: Frosty Message Error while executing (script-fu-frosty-logo-alpha 1 3 100 '(255 255 255)) ERROR: Procedural database execution failed: (gimp_edit_stroke 3) In the console, when this happens, gimp prints: (gimp:4699): Gimp-Paint-CRITICAL **: gimp_paint_core_stroke_boundary: assertion `bound_segs != NULL && n_bound_segs > 0' failed
The script works correctly as long as the effect size is smaller than the text size. Perhaps this should somehow be checked instead of running into an error.
2007-05-03 Sven Neumann <sven@gimp.org> Handle the core part of bug #434274: * app/core/gimpchannel.c (gimp_channel_real_boundary): return FALSE for an empty channel. * app/core/gimpitem.[ch]: added a progress parameter to gimp_item_stroke. * app/core/gimpchannel.c (gimp_channel_stroke) * app/core/gimpselection.c (gimp_selection_stroke): pass progress to gimp_message(). * app/actions/vectors-commands.c * app/actions/select-commands.c * app/dialogs/stroke-dialog.c * app/vectors/gimpvectors.c * tools/pdbgen/pdb/edit.pdb * tools/pdbgen/pdb/paths.pdb: changed accordingly. * app/pdb/edit_cmds.c * app/pdb/paths_cmds.c: regenerated. * app/core/gimplayermaskundo.c: added a missing cast. The script fails with a proper warning dialog now. But we should add some sanity checks to the script and try to avoid the error.
This reminds me of a similar sounding problem that affected the neon logo script (see bug #167260). Would a similar solution work here?
Yes, a similar solution is needed here.
I can reproduce the problem with GIMP 2.4.3. Adjusting the version field accordingly...
I already solved this bug - there is another bug report here: http://bugzilla.gnome.org/show_bug.cgi?id=472316 I attached the new version of the script there (I'll also attach it here in a moment)
Created attachment 105769 [details] [review] BugFix version for Frosty script-fu he attached file is a bug fix version of Script-Fu "Frosty" - the bug fix applies on the "alpha to logo" section and it is now running OK with GIMP 2.4 I have fixed some offsets and it should work fine (works fine on my PC)
Created attachment 109109 [details] [review] frosty-logo-fix.patch Here is a diff instead of the whole file and converted to have DOS line endings. Someone please separate cleanups in the script from actual bug fixes and then we can review this patch again.
this was answered in bug 472316 since it's a duplicate of this bug http://bugzilla.gnome.org/show_bug.cgi?id=472316 reviewed and fixed patch can be found there, this is waiting for the 2.6 release. "Comment #17 from Sven Neumann 2008-02-27 19:45 UTC [reply] This check can and should be done nicer. The error message also needs to be marked for translation. Since this introduces a new string, it can not be done in the stable branch. Moving this to the 2.6 milestone."
After the latest fix in bug #472316 which is similar to this bug, I do believe this should be closed and marked as Status: RESOLVED Resolution: FIXED
As you wish (but I'll close it at OBSOLETE)