GNOME Bugzilla – Bug 431060
[usability] use pygtk's load_icon as much as possible
Last modified: 2009-09-06 07:25:33 UTC
I think some of the icons that PiTiVi ships can be provided by the user's theme instead, namely: pitivi/pixmaps/pitivi-video.png pitivi/pixmaps/pitivi-sound.png pitivi/pixmaps/pitivi-file.png It would be much better to use the user's native theme icons: http://pygtk.org/pygtk2reference/class-gtkicontheme.html#method-gtkicontheme--load-icon It would look something like this: load_icon("video-x-generic", 48, 0) load_icon("audio-x-generic", 48, 0) load_icon("misc", 48, 0) (bonus: you can change the size to anything other than 48, and icon themes often provide SVG versions nowadays). This would make PiTiVi better integrated into the desktop.
Fixed in svn. 2007-04-18 Edward Hervey <edward@fluendo.com> * pitivi/ui/sourcefactories.py: Use default gtk theme icons for files, audio files and video files. Fixes #431060
Wow, that was fast! Thanks, it looks much better already for sound files :) I think you forgot some other places however, because I still see some "old" video icons in the timeline: jeff@kaname:~/trunks/pitivi/pitivi/ui$ grep -Rn "png" *.py complexsource.py:55: self.thumbnailsurface = cairo.ImageSurface.create_from_png(os.path.join(get_pixmap_dir(), "pitivi-video.png")) timelineobjects.py:556: self.thumbnail = gtk.gdk.pixbuf_new_from_file(os.path.join(get_pixmap_dir(), "pitivi-video.png")) mainwindow.py:172: self.set_icon_from_file(configure.get_global_pixmap_dir() + "/pitivi.png") mainwindow.py:257: abt.set_icon_from_file(configure.get_global_pixmap_dir() + "/pitivi.png") #Note: these two depend on pitivi.png/.svg being present in gnome/tango icon themes; in any case, pitivi needs to "supply" that icon to the HighContrast theme. Example: http://code.google.com/p/specto/issues/detail?id=25
looks like this fix has screwed up it loading in kde
oneforall : could you paste here what errors/warnings come up on the console ? Don't have kde to test this.
I think we're done with this. Closing.