After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 430780 - Scroll to the track being ripped
Scroll to the track being ripped
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: interface
2.14.x
Other Linux
: Normal enhancement
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-17 20:11 UTC by Sven Arvidsson
Modified: 2008-01-05 13:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Patch to add scroll to track being ripped or played. (1.93 KB, patch)
2008-01-04 21:09 UTC, Dave Meikle 		committed Details | Review
Patch to add scroll to track being ripped or played using scroll_to_cell (1.95 KB, patch)
2008-01-04 23:43 UTC, Dave Meikle 		none Details | Review

Description Sven Arvidsson 2007-04-17 20:11:25 UTC 
[ Forwarded from http://bugs.debian.org/400264 ]

"When it starts playing a file, Rhythmbox scrolls its file list to display the file.  Sound Juicer does not do so when it starts ripping a track.  I think it would be nice if it did so."
Comment 1 Ross Burton 2008-01-02 21:21:15 UTC 
Yes, this sounds like a great idea.  Simply call gtk_tree_view_scroll_to_cell() when changing the currently played or ripped track, so that the treeview scrolls.  Perfect gnome-love material.
Comment 2 Dave Meikle 2008-01-04 21:09:27 UTC 
Created attachment 102163 [details] [review]
Patch to add scroll to track being ripped or played.
Comment 3 Ross Burton 2008-01-04 21:38:52 UTC 
I'd prefer not to use _set_cursor() as that moves the focus, can you try using gtk_tree_view_scroll_to_cell()?
Comment 4 Dave Meikle 2008-01-04 23:43:31 UTC 
Created attachment 102179 [details] [review]
Patch to add scroll to track being ripped or played using scroll_to_cell

Updated patch to use gtk_tree_view_scroll_to_cell.
Comment 5 Dave Meikle 2008-01-04 23:47:22 UTC 
I have uploaded an updated patch using gtk_tree_view_scroll_to_cell() but I must admit I prefer the _set_cursor() one.

Before you think I blatantly ignored your comment in Comment #1 (I wouldn't do that :-), I had made a conscious decision to use it and not call gtk_widget_grab_focus() so I didn't move the keyboard focus to the cell, instead leaving it on the stop button.

Cheers,
Dave
Comment 6 Ross Burton 2008-01-05 13:19:25 UTC 
Ah, in that case, I'll go with the first patch, as you've seen then both in use.  Thanks!