After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 427681 - Freezes on close action if lircd is running
Freezes on close action if lircd is running
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
2.18.x
Other Linux
: Normal critical
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-04-08 21:28 UTC by Sven Arvidsson
Modified: 2007-04-09 23:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Remove g_free (298 bytes, patch)
2007-04-09 16:57 UTC, Philip Withnall 		committed Details | Review

Description Sven Arvidsson 2007-04-08 21:28:01 UTC 
This bug was forwarded from the Debian BTS.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=418020

"Totem freezes every time i close it. After some investigation i could see it 
doesn't crash if lircd isn't running. On a terminal I get this after i tried to 
close totem:

acidman@acidmachine:~$ totem
*** glibc detected *** double free or corruption (fasttop): 0x084341d8 ***"

Version 2.18.1 with Xine backend.

acidman@acidmachine:~$ LD_LIBRARY_PATH=/usr/lib/debug gdb totem
GNU gdb 6.6-debian
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i486-linux-gnu"...
Using host libthread_db library "/usr/lib/debug/libthread_db.so.1".
(gdb) run
Starting program: /usr/bin/totem 
Failed to read a valid object file image from memory.
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 25707)]
[New Thread 32769 (LWP 25710)]
[New Thread 16386 (LWP 25711)]
[New Thread 32771 (LWP 25712)]
[New Thread 49156 (LWP 25713)]
[Thread 49156 (LWP 25713) exited]
[New Thread 65540 (LWP 25714)]
[Thread 65540 (LWP 25714) exited]
[New Thread 81925 (LWP 25715)]
[Thread 81925 (LWP 25715) exited]
[New Thread 98308 (LWP 25716)]
[New Thread 114693 (LWP 25717)]
[New Thread 131078 (LWP 25718)]
[New Thread 147463 (LWP 25719)]
[New Thread 163848 (LWP 25720)]
[New Thread 180233 (LWP 25721)]
*** glibc detected *** double free or corruption (fasttop): 0x0841b868 ***

Program received signal SIGABRT, Aborted.

+ Trace 126118

Thread 16384 (LWP 25707)

  • #0 kill
    from /usr/lib/debug/libc.so.6
  • #1 pthread_kill
    at signals.c line 69
  • #2 __pthread_raise
    at signals.c line 200
  • #3 *__GI_raise
    at ../linuxthreads/sysdeps/unix/sysv/linux/raise.c line 38
  • #4 *__GI_abort
    at ../sysdeps/generic/abort.c line 88
  • #5 __libc_message
    at ../sysdeps/unix/sysv/linux/libc_fatal.c line 145
  • #6 malloc_printerr
  • #7 *__GI___libc_free
    at malloc.c line 3404
  • #8 g_free
    from /usr/lib/libglib-2.0.so.0
  • #9 totem_remote_finalize
    at totem-remote.c line 233
  • #10 g_object_unref
    from /usr/lib/libgobject-2.0.so.0
  • #11 totem_action_exit
    at totem.c line 200
  • #12 totem_action_handle_key_press
    at totem.c line 2648
  • #13 _gtk_marshal_BOOLEAN__BOXED
    at /tmp/buildd/gtk+2.0-2.10.11/gtk/gtkmarshalers.c line 84
  • #14 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #15 ??
    from /usr/lib/libgobject-2.0.so.0
  • #16 ??
  • #17 ??
  • #18 ??
  • #19 ??
  • #20 ??
  • #21 ??
  • #22 ??
  • #23 ??
    from /lib/ld-linux.so.2
  • #24 ??
  • #25 ??
  • #26 ??
  • #27 ??
  • #28 ??
  • #29 ?? 
(gdb)
Comment 1 Philip Withnall 2007-04-09 16:57:10 UTC 
Created attachment 86055 [details] [review]
Remove g_free

Looking at the LIRC documentation (http://www.lirc.org/html/technical.html#library), no extra free calls are needed after lirc_freeconfig. Attached is a patch to remove our call to g_free.
Comment 2 Bastien Nocera 2007-04-09 17:24:35 UTC 
Please don't reassign bugs to yourself, thanks.
Comment 3 Bastien Nocera 2007-04-09 22:18:13 UTC 
Thanks for the patch, committed to gnome-2-18 and trunk.

2007-04-09  Bastien Nocera  <hadess@hadess.net>

        * src/totem-remote.c: (totem_remote_finalize): Patch from Philip Withnall
        <bugzilla@tecnocode.co.uk> to avoid crashing on exit when LIRC is
        being used (Closes: #427681)