After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 422385 - vte appears at the top of the root window even when packed at the bottom of it
vte appears at the top of the root window even when packed at the bottom of it
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.16.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks: 421910
 
 
Reported: 2007-03-24 19:00 UTC by Dodji Seketeli
Modified: 2007-03-25 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test-case showing the problem (1.17 KB, text/plain)
2007-03-24 19:04 UTC, Dodji Seketeli
  Details
a patch that fixes the problem (741 bytes, patch)
2007-03-24 19:11 UTC, Dodji Seketeli
committed Details | Review

Description Dodji Seketeli 2007-03-24 19:00:05 UTC
Whenever I pack the VteTerminal widget in a box, and pack the box in a toplevel window, the vte terminal always appears at the top the root window, not in the box  where it is supposed to be.

I will attach a little code snippet that shows the problem.
Comment 1 Dodji Seketeli 2007-03-24 19:04:24 UTC
Created attachment 85230 [details]
test-case showing the problem

In this test case what you should see is two labels at the top of the window, with the text "should be visible". _BELOW_ these two labels, you should see the vte widget.

What you actually see is the vte widget appearing at the top of the toplevel window.
Comment 2 Dodji Seketeli 2007-03-24 19:11:38 UTC
Created attachment 85231 [details] [review]
a patch that fixes the problem

It appears that in the vte_terminal_realize() function, the widget->window was being created at coordinates (0,0), in root window space.

The patch just creates widget->window at (widget.allocation.x, widget.allocation.y).

Trying the test case I attached earlier shows that the bug has been fixed.
Comment 3 Chris Wilson 2007-03-25 14:13:16 UTC
Good work, thanks.

r1858: 2007-03-25  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 422385 – vte appears at the top of the root window even when
	packed at the bottom of it

	Patch by Dodji Seketeli.

	* src/vte.c (vte_terminal_size_allocate), (vte_terminal_realize):
		Honour the allocated position when realizing the widget.