After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419136 - [pending] Planner toggle button in main window not accessible
[pending] Planner toggle button in main window not accessible
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.22.0
Assigned To: Eitan Isaacson
Orca Maintainers
Depends on: 337382
Blocks:
 
 
Reported: 2007-03-16 22:00 UTC by Willie Walker
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revision #1 (3.59 KB, patch)
2008-02-11 19:07 UTC, Rich Burridge 		committed Details | Review

Description Willie Walker 2007-03-16 22:00:28 UTC 
This is a tracking bug for bug 337382.  The problem is that planner should use the LABEL_FOR relationship to match up each toggle button with the appropriate label.
Comment 1 Willie Walker 2007-05-25 16:27:28 UTC 
Removing target milestone from [blocked] bugs.  We have little control over them, so we're better off letting priority and severity be our guide for poking the related components.
Comment 2 Rich Burridge 2008-02-11 19:07:36 UTC 
Created attachment 104979 [details] [review]
Revision #1

This is the patch we will have to apply to the planner.py script
when bug #337382 is fixed.
Comment 3 Rich Burridge 2008-02-11 20:20:40 UTC 
Removing the "[blocked]" as the underlying bug has been fixed.
Comment 4 Willie Walker 2008-02-12 18:03:08 UTC 
Given the information that Orca's planner script no longer works well with the fixed planner functionality, please commit this patch for GNOME 2.21.92 (assuming you have tested it).  Thanks!
Comment 5 Rich Burridge 2008-02-12 18:24:40 UTC 
Patch committed. Moving to "[pending]" state.
Comment 6 Rich Burridge 2008-02-12 20:37:30 UTC 
Still problems with this.

The latest changes to planner.py for contracted braille are causing a
traceback:

Traceback (most recent call last):

+ Trace 188993

  • File "/usr/lib/python2.5/site-packages/orca/focus_tracking_presenter.py", line 625 in _processObjectEvent 
    s.processObjectEvent(event)
  • File "/usr/lib/python2.5/site-packages/orca/script.py", line 319 in processObjectEvent 
    self.listeners[key](event)
  • File "/usr/lib/python2.5/site-packages/orca/default.py", line 3509 in onStateChanged 
    self.onFocus(event)
  • File "/usr/lib/python2.5/site-packages/orca/default.py", line 3016 in onFocus 
    orca.setLocusOfFocus(event, newFocus)
  • File "/usr/lib/python2.5/site-packages/orca/orca.py", line 208 in setLocusOfFocus 
    orca_state.locusOfFocus)
  • File "/usr/lib/python2.5/site-packages/orca/focus_tracking_presenter.py", line 935 in locusOfFocusChanged 
    newLocusOfFocus)
  • File "/usr/lib/python2.5/site-packages/orca/default.py", line 2578 in locusOfFocusChanged 
    self.updateBraille(newLocusOfFocus)
  • File "/usr/lib/python2.5/site-packages/orca/default.py", line 2943 in updateBraille 
    braille.setFocus(result[1])
  • File "/usr/lib/python2.5/site-packages/orca/braille.py", line 904 in setFocus 
    offset += _regionWithFocus.cursorOffset - _displaySize[0] + 1
TypeError: unsupported operand type(s) for -: 'str' and 'int' 

We should be passing in a True or False as the third parameter to:

        componentRegion = braille.Component(obj, text, indicator)

but indicator is:

        indicator=\
            settings.brailleRadioButtonIndicators[brailleindicatorindex]

and settings.brailleRadioButtonIndicators[brailleindicatorindex] is:

brailleRadioButtonIndicators = ["& y", "&=y"]
Comment 7 Eitan Isaacson 2008-02-12 22:28:49 UTC 
It was a tiny issue that I fixed in trunk. A keyword for the argument was needed.
Comment 8 Rich Burridge 2008-02-12 23:24:48 UTC 
Verified. Thanks Eitan!