After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 41852 - Items should be restored to original name when moved out of trash
Items should be restored to original name when moved out of trash
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: trash backend
git master
Other All
: Normal enhancement
: ---
Assigned To: Christian Neumair
gvfs-maint
Depends on:
Blocks: 41850
 
 
Reported: 2000-08-01 15:45 UTC by Maciej Stachowiak
Modified: 2008-08-16 10:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Proposed patch (820 bytes, patch)
2008-07-22 15:20 UTC, Christian Neumair
committed Details | Review

Description Maciej Stachowiak 2001-09-10 00:34:03 UTC
Items in the trash are renamed if there is a name conflict (due to multiple
files with the same name being deleted). If you drag them back out, however, the
original name should be restored, otherwise, dragging an item into the trash and
back out could change the name. Also, perhaps items should always show up with
the original name in the trash, regardless of renaming.



------- Additional Comments From darin@bentspoon.com 2000-08-01 18:45:34 ----

This goes beyond what trash implementations on others systems do, and is
deferrable, especially since it only affects cases where you move an item back
out of the trash, which is relatively rare.



------- Additional Comments From eli@eazel.com 2000-10-16 19:43:21 ----

Batch-assigning QA ownership of remaining bugs to eli@eazel.com



------- Additional Comments From eli@eazel.com 2001-03-26 11:20:32 ----

SPAAAAAAAAAM! 

(Jon Allen has taken these components; QA Assigning bugs to him.)



------- Additional Comments From snickell@stanford.edu 2001-07-23 00:38:36 ----

Taking bugs previously assigned to Pavel, assigning them to myself. Will parse
them out at my leisure , but many are GnomeVFS bugs we should look at for 2.0



------- Additional Comments From mjs@noisehavoc.org 2001-07-23 01:17:10 ----

Move to unassigned. I'll probably want to take a crack at some of these myself,
and Seth says he is unlikely to.




------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:34 -------
Comment 1 Aschwin van der Woude 2002-11-16 20:16:37 UTC
This behaviour still exists in 2.1.2
Comment 2 Mark Finlay 2003-02-03 19:54:08 UTC
This would need to be implemented if undelete is to be added (bug 41850)
Comment 3 Christian Neumair 2008-07-21 14:58:41 UTC
Good catch. I think this can be fixed by spefiying the G_FILE_ATTRIBUTE_STANDARD_COPY_NAME of trash:///. Reassigning to gvfs / trash backend.
Comment 4 Christian Neumair 2008-07-22 15:20:51 UTC
Created attachment 115016 [details] [review]
Proposed patch

Proposed patch. Sets the copy name ot the display name in case it is valid UTF-8.
Comment 5 Matthias Clasen 2008-08-15 22:06:25 UTC
Have you tested this ? 
Comment 6 Matthias Clasen 2008-08-15 22:20:31 UTC
Nevermind, I just tested it, and it works.
Comment 7 Christian Neumair 2008-08-16 10:07:48 UTC
Done, closing.