Bug 417196 – Eog crashes when no argument is given

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 417196 - Eog crashes when no argument is given


Summary:	Eog crashes when no argument is given


Status:	RESOLVED FIXED

Product:	eog
Classification:	Core
Component:	general
Version:	2.18.x
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	EOG Maintainers
QA Contact:	EOG Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-03-11 19:34 UTC by Frédéric Bellaiche
Modified:	2007-03-15 23:10 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
fix (975 bytes, patch) 2007-03-12 20:18 UTC, Claudio Saavedra	none	Details \| Review
correct fix (912 bytes, patch) 2007-03-12 20:28 UTC, Claudio Saavedra	committed	Details \| Review

Description Frédéric Bellaiche 2007-03-11 19:34:35 UTC

Steps to reproduce:
1. Launch eog 2.18.0 (no argument given)


Stack trace:
Distribution: Debian 3.1
Gnome Release: 2.17.92 2007-02-26 (quantum-bits.org)
BugBuddy Version: 2.17.4

System: Linux 2.6.20.2 #1 SMP PREEMPT Sat Mar 10 15:45:58 CET 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70101000
Selinux: No
Accessibility: Disabled
GTK+ Theme: Human-Graphite
Icon Theme: OrangoTango

Memory status: size: 51441664 vsize: 51441664 resident: 22155264 share: 10264576 rss: 22155264 rss_rlim: 4294967295
CPU usage: start_time: 1173641454 rtime: 52 utime: 43 stime: 9 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/eog'

[?1034hUsing host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1237063984 (LWP 8516)]
0xffffe410 in __kernel_vsyscall ()

+ Trace 117784

Thread 1 (Thread -1237063984 (LWP 8516))

#0 __kernel_vsyscall
#1 __waitpid_nocancel
from /lib/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 872
#3 <signal handler called>
#4 __kernel_vsyscall
#5 *__GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 67
#6 *__GI_abort
at abort.c line 88
#7 IA__g_logv
at gmessages.c line 497
#8 IA__g_log
at gmessages.c line 517
#9 IA__g_return_if_fail_warning
#10 IA__g_signal_connect_data
at gsignal.c line 1638
#11 eog_window_open
at eog-window.c line 4216
#12 open_uri_list_cb
at main.c line 210
#13 handle_cmdline_args
at main.c line 567
#14 g_idle_dispatch
at gmain.c line 3928
#15 IA__g_main_context_dispatch
at gmain.c line 2045
#16 g_main_context_iterate
at gmain.c line 2677
#17 IA__g_main_loop_run
at gmain.c line 2881
#18 IA__gtk_main
at gtkmain.c line 1148
#19 main
at main.c line 651
#0 __kernel_vsyscall




Other information:
version: 2.18.0

Comment 1 Claudio Saavedra 2007-03-12 20:18:10 UTC

Created attachment 84447 [details] [review]
fix

This is the obvious fix. I am sorry for having left this in.

Comment 2 Claudio Saavedra 2007-03-12 20:28:55 UTC

Created attachment 84449 [details] [review]
correct fix

Actually, this is the fix. The if block is not supposed to include the call to eog_wrap_list_set_model ()

Comment 3 Claudio Saavedra 2007-03-13 02:12:31 UTC

Unfortunately it was too late to include for 2.18.0.

Comment 4 Claudio Saavedra 2007-03-15 23:10:28 UTC

Fixed in trunk:

2007-03-15  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * shell/eog-window.c: (eog_window_open): Fix critical warning when 
        starting EOG without a file/directory to open. Fixes bug #417196.