After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 416321 - [eog-ng] Use tooltips to show image information in the thumbview
[eog-ng] Use tooltips to show image information in the thumbview
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: collection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Claudio Saavedra
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-09 04:18 UTC by Claudio Saavedra
Modified: 2007-04-25 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first implementation (6.92 KB, patch)
2007-03-09 04:40 UTC, Claudio Saavedra
none Details | Review
first implementation (6.92 KB, patch)
2007-03-09 04:41 UTC, Claudio Saavedra
none Details | Review

Description Claudio Saavedra 2007-03-09 04:18:00 UTC
We can use the GTK+ 2.11 sexy tooltips to show image details in the thumbview. Do I need to say anything else? ;-)
Comment 1 Claudio Saavedra 2007-03-09 04:40:01 UTC
Created attachment 84289 [details] [review]
first implementation

Ok, here goes the first implementation I did.

- Modified EogImage.real_load() to add support to load only the dimensions of the image. This will try first to get them from the thumbnail metadata, otherwise from the image.
- I added a private quick_get_dimension () method to EogImage. It will attempt to retrieve the image size from the thumbnail.[1]
- If that method can't find the dimensions, EogImage.real_load() will load from the image only enough info until the "size-prepared" signal is emitted and we have the dimension.
- If exif data is available in the image, we display also the date the image was taken.

Comments?

[1] This is probably not going to work yet, as libgnomeui thumbnail factory doesn't add this metadata to thumbnails. I've cooked a patch to fix this, it's waiting to be reviewed in bug #143470.
Comment 2 Claudio Saavedra 2007-03-09 04:41:27 UTC
Created attachment 84290 [details] [review]
first implementation

Ok, here goes the first implementation I did.

- Modified EogImage.real_load() to add support to load only the dimensions of the image. This will try first to get them from the thumbnail metadata, otherwise from the image.
- I added a private quick_get_dimension () method to EogImage. It will attempt to retrieve the image size from the thumbnail.[1]
- If that method can't find the dimensions, EogImage.real_load() will load from the image only enough info until the "size-prepared" signal is emitted and we have the dimension.
- If exif data is available in the image, we display also the date the image was taken.

Comments?

[1] This is probably not going to work yet, as libgnomeui thumbnail factory doesn't add this metadata to thumbnails. I've cooked a patch to fix this, it's waiting to be reviewed in bug #143470.
Comment 3 Lucas Rocha 2007-04-25 22:32:33 UTC
Ok, fixed a bunch of things and commited in trunk. Thanks Claudio!

2007-04-26  Lucas Rocha  <lucasr@gnome.org>

        Show tooltips with image's general information on thumbnails
        pane. Patch from Claudio Saavedra. Fixes bug #416321.

        * src/eog-thumb-view.c (tb_on_query_tooltip_cb,
        eog_thumb_view_get_image_from_path, eog_thumb_view_popup_menu,
        eog_thumb_view_init): added tooltip handling in thumbnails view.
        * src/eog-window.c (update_status_bar): improve i18n details for
        status bar content.
        * src/Makefile.am: made all EXIF-related code optional.
        * src/eog-image.c (eog_image_get_dimension_from_thumbnail, 
        eog_image_real_load): added support for loading only image
        dimensions.
        * configure.ac: added checks for new tooltip API in GTK+.